Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings of 'int' type is broken #701

Closed
Sing-Li opened this issue Sep 5, 2015 · 0 comments
Closed

Settings of 'int' type is broken #701

Sing-Li opened this issue Sep 5, 2015 · 0 comments
Assignees
@Sing-Li
Labels
type: bug

Comments

@Sing-Li
Copy link
Member

Sing-Li commented Sep 5, 2015

Any 'int' typed value currently displayed as a spin-button on the settings screen will not save. For example:

https://github.com/RocketChat/Rocket.Chat/blob/master/packages/rocketchat-lib/settings/server/startup.coffee#L10

'string' and 'boolean' types are saving fine.
@Sing-Li Sing-Li changed the title Settings is broken Settings of 'int' type is broken Sep 5, 2015
Sing-Li added a commit that referenced this issue Sep 5, 2015
@Sing-Li
fix problem of saving int typed setting #701
fb9d7ef
@Sing-Li Sing-Li self-assigned this Sep 5, 2015
@Sing-Li Sing-Li mentioned this issue Sep 5, 2015
Merged
engelgabriel added a commit that referenced this issue Sep 5, 2015
@engelgabriel
Merge pull request #704 from RocketChat/fix-settings-int-type
a36be48 
fix problem of saving int typed setting #701
shedoev added a commit to sibdigital/rgrt that referenced this issue Sep 10, 2020
@shedoev
RocketChat#701 Исправление оформления
14e0be7
shedoev added a commit to sibdigital/rgrt that referenced this issue Sep 11, 2020
@shedoev
RocketChat#701 Исправление оформления | Цвет шрифта кнопок
d1bc6f7
Shailesh351 pushed a commit to Shailesh351/Rocket.Chat that referenced this issue May 26, 2021
@ear-dev
Merge pull request RocketChat#701 from Shailesh351/sb_api_livechat_fi…
a4ab7b7 
…lter

Add livechat/filter post API Endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sing-Li Sing-Li

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sing-Li