Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename channel/group throws error #547

Closed
rwakida opened this issue Aug 22, 2015 · 1 comment
Closed

Rename channel/group throws error #547

rwakida opened this issue Aug 22, 2015 · 1 comment
Assignees
@rodrigok
Labels
type: bug
Milestone
0.8.0

Comments

@rwakida
Copy link
Contributor

rwakida commented Aug 22, 2015

To replicate:

  1. create a channel c1
  2. rename channel c2
  3. notice url is wrong and room name disappears
  4. click on c2 channel in the SideNav.
  5. console error: TypeError: Cannot read property '_id' of undefined
  6. Rooms no longer load properly

Renaming the room leaves the old room name in RoomManager openedRooms cache. On tracker invalidation, openedRooms are retrieved but invalid room returns undefined.
rwakida added a commit that referenced this issue Aug 22, 2015
@rwakida
Fixes #547 where editing channel/group name crashed RoomManager's ope…
13fae7d 
…nRoom

tracker

Bug is a side effect of User friendly URLs #18.  The commit changed Room
subscription based on room id to room name.. It created a new room
subscription, but didn't remove the old name from the RoomManager's
openedRooms cache.  Whenever the tracker ran, an 'undefined' room
was returned because the old room name was invalid.

Adds code that observes room name changes, closes the old room, and
opens the new room via the RoomManager.  There is still a small bug
where the room name changed message is not displayed to the user who changed
the name probably due to the message stream subscribing after the message was sent.
@rodrigok
Copy link
Member

Fixed via #570

@rodrigok rodrigok added this to the v1.0 milestone Aug 25, 2015
@rodrigok rodrigok self-assigned this Aug 25, 2015
Peym4n pushed a commit to redlink-gmbh/Rocket.Chat that referenced this issue Apr 4, 2019
@vickyokrm
Merge pull request RocketChat#547 from assistify/merge/0.71
62a827e 
Merge 0.71
@BMondly BMondly mentioned this issue Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodrigok rodrigok

Labels
type: bug
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
2 participants
@rodrigok @rwakida