Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triggering custom OAuth iframe command with redirect login style send user to wrong location #5042

Closed
fabiomontefuscolo opened this issue Nov 24, 2016 · 0 comments · Fixed by #5043
Closed

Triggering custom OAuth iframe command with redirect login style send user to wrong location #5042

fabiomontefuscolo opened this issue Nov 24, 2016 · 0 comments · Fixed by #5043
Labels
feat: oauth / sso

Comments

@fabiomontefuscolo
Copy link
Contributor

Your Rocket.Chat version:develop

@rodrigok I had a misunderstanding about redirectUri, so in my last contribution I took the wrong info to redirect user after a successful login in redirect style.

The bug lives exactly at https://github.com/RocketChat/Rocket.Chat/blob/develop/packages/rocketchat-ui/lib/iframeCommands.js#L27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat: oauth / sso
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix redirectUrl after custom oauth successful login initiated by ifra… hacklabr/Rocket.Chat
2 participants
@fabiomontefuscolo @MartinSchoeler