Message editing settings

[marceloschmidt]

Allow/Disallow message editing
Allow/Disallow message deleting
Show/Hide that a message has been edited/deleted
Keep history of edited/deleted messages

[rwakida]

hi @marceloschmidt I noticed you implemented these changes, but it looks like the message template is not reactive due to "nrr". Are you planning on making the icons reactive to setting change? For example, the edit icon is not reactively removed after the Message_AllowEditing is set to false. Thanks.

[marceloschmidt]

Hey @rwakida. We have to think about performance vs usability. Do we really need those icons to immediately reflect settings? Is that something that will be changed more oftenly than not?

[rwakida]

@marceloschmidt 😄 agreed. My only gripe is that the edit icon is still visible with pointer cursor, but no feedback is given to the user as to why they can't edit, and the delete icon is visible and still works.

Also, we need to protect the serverside methods. The updateMessage and deleteMessage need to check the settings.

[marceloschmidt]

You're right! Thanks for the reminder. I'll work on that tonight.

Marcelo Schmidt

On Wed, Aug 19, 2015 at 8:17 PM, Reid Wakida [email protected]
wrote:

[image: 😄] agreed. My only gripe is that the edit icon is still
visible with pointer cursor, but no feedback is given to the user as to why
they can't edit, and the delete icon is visible and still works.

Also, we need to protect the serverside methods. The updateMessage and
deleteMessage need to check the settings.

—
Reply to this email directly or view it on GitHub
#374 (comment)
.

[rwakida]

thanks! we need that in our fork.

[marceloschmidt]

@rwakida that is done