Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stab the heart -> Hardcoded SVG in /rocketchat-ui-master/master/loading.html #2578

Closed
lunitic opened this issue Mar 21, 2016 · 9 comments
Closed

Comments

@lunitic
Copy link

lunitic commented Mar 21, 2016

Your Rocket.Chat version: (make sure you are running the latest)

There is a hardcoded (rocketchat loading icon) in the file
/rocketchat-ui-master/master/loading.html

Would it possible to remove the SVG from the files and put it in the public/images/logo folder instead.
As it is now you have to remember to put the file back after a upgrade of the server.

@engelgabriel
Copy link
Member

I think we should replace the rocket for a standard loading, that uses less CPU.

@engelgabriel engelgabriel added this to the 0.25.0 milestone Mar 22, 2016
@Sing-Li
Copy link
Member

Sing-Li commented Mar 22, 2016

I think this is a cornerstone part of "The Rocket.Chat Experience"

The "pumping heart" - that gives Rocket.Chat the "soul" that so many adore.

Please consider to re-consider.

@Sing-Li Sing-Li changed the title Hardcoded SVG in /rocketchat-ui-master/master/loading.html Stab the heart -> Hardcoded SVG in /rocketchat-ui-master/master/loading.html Mar 22, 2016
@engelgabriel
Copy link
Member

I will reconsider...

@mrplow
Copy link

mrplow commented Mar 22, 2016

I think thats going a little far to say its the cornerstone part of "The Rocket.Chat Experience". That's more owning your own data, not the loading image.
The "pumping heart" is most definitely slowing down switching channels on lower end mobile devices for our team members.

@k0nsl
Copy link
Contributor

k0nsl commented Mar 22, 2016

I say, keep it, but let us customize it, or even add the ability to disable it.

@dupree972
Copy link

Yeah, it’s friendly looking and end users I think like that Rocket has that inviting look and feel as opposed to some of the less attractive options like Zulip.

On Mar 22, 2016, at 3:33 PM, k0nsl [email protected] wrote:

I say, keep it, but let us customize it, or even add the ability to disable it.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub #2578 (comment)

@engelgabriel
Copy link
Member

Ok, my goals would be:

  • Keep the logo but make it configurable via admin ASSETS panel
  • Use a less CPU intensive animation

@lunitic
Copy link
Author

lunitic commented Mar 22, 2016

@engelgabriel Sound goods,

I also like the symbol, but on a customized server people just get confused of a big unknown logotype

@engelgabriel engelgabriel modified the milestones: 0.25.0, 0.26.0, 0.27.0 Apr 5, 2016
@marceloschmidt marceloschmidt modified the milestone: 0.27.0 Apr 18, 2016
@engelgabriel
Copy link
Member

Duplicate of #613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants