-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to create Favicon.ico #1888
Comments
Hey @tuudik we have identified what we think is a problem on our File Upload. Would you mind sending us the file you are creating to [email protected], so we can improve and fix this for everyone else? Thanks! |
Favicon sent:) One question more, when in iOS safari, sending shortcut to homescreen, it will use Rocket.Chat icon, is it expected behaviour? |
Hmm but I used chrome:( |
@tuudik OS X, Windows or Linux? |
Hello, I had the same problem yesterday using Opera (Chrome based engine) and Windows 7 pro. The browser identified correctly the file as a .ico type, but the chat instance would not accept it due to "Invalid file type" |
Windows 8.1 Pro |
I have the same problem with .ico extension. It says : Invalid file type : image/vnd.microsoft.icon |
@LeCoupa Which Rocket.Chat version are you using? |
I just used one week ago.
|
@LeCoupa can you go to |
@rodrigogs : "version": "0.15.0" |
@LeCoupa which browser and OS are you using? I can't reproduce your problem |
@LeCoupa Ok, the problem is that this mime type doesn't have extension in the library that we are using https://github.com/jshttp/mime-db/blob/master/db.json?ts=2#L5522-L5525 I will try to solve that |
@LeCoupa My latest commit solve your problem d790090?ts=2 |
Can we add mime types for Apple Keynote, Pages and Numbers? I am unable to upload those. |
@alvarow for favicon? 😸 This verification is only for assets like favicon, logo, etc. For normal uploads you can change the list of acceptable file types for upload in admin area under "File Uploads" section. |
Well. on File uploads... there's a white list of mime types too ... I added those, yet I still can't upload |
@alvarow can you create a new issue with more details about your problem? |
sure can. |
@rodrigok I reinstalled Rocket with But it seems that I still get this error: Here is the favicon if you want to try: http://d1ujqdpfgkvqfi.cloudfront.net/favicon-generator/htdocs/favicons/2014-04-28/057994f5fa4400c347d690c07212b0e2.ico |
@LeCoupa you are downloading the latest release that is from our master, we do a new release every monday. To get the fix you need to download our development version https://github.com/RocketChat/Rocket.Chat/archive/develop.zip |
It is working on my side! Thank you @rodrigok :-) |
@LeCoupa ur welcome 😄 |
Hi, I am still having this issue with 0.57.2. What am I doing wrong? Any idea @rodrigok ? Ralph |
0.57.2 linux chrome, firefox, desktop client with same result |
Even trying to re-upload the default favicon.ico that comes with Rocketchat fails with the same error. |
indeed same issue here still persistent for over a year |
Indeed, us as well on commit 65e06c2. Here's a file I'm having trouble with: rocket-chat-discourse.ico.gz Created using:
|
Any tips on creating a file that does work? |
Not really; the file does work it's the software that's broken. From: [email protected]: February 24, 2018 12:34To: [email protected] to: [email protected]: [email protected]; [email protected]: Re: [RocketChat/Rocket.Chat] How to create Favicon.ico (#1888) Any tips on creating a file that does work?
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.
|
Can we reopen this issue as many people still have issues with it? |
I'm having the same issue, any solution? |
Hello everyone, I was getting this error and there is no real solution on the web. The solution is:
Screenshot is on the link: https://hackerspace.ist/ico_problem_solution.png Have a nice day! |
Hi,
I have tried creating favicon with GIMP.
I have three different layers with icon sizes: 16, 32, 48.
Everytime I try to upload, error message Invalig File Type appears. Nothing in Debug log.
Help pls:)
The text was updated successfully, but these errors were encountered: