Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlisted emoji name in emoji picker's recently used list crashes room UI #14575

Closed
tassoevan opened this issue May 21, 2019 · 0 comments · Fixed by #14576
Closed

Unlisted emoji name in emoji picker's recently used list crashes room UI #14575

tassoevan opened this issue May 21, 2019 · 0 comments · Fixed by #14576
Assignees
Milestone

Comments

@tassoevan
Copy link
Contributor

Description:

Before EmojiOne update, there was an emoji named :hot_dog:, now renamed as :hotdog:. Since it was in the recently used emoji list on emoji picker, the entire room template failed to render.

Steps to reproduce:

  1. Edit localStorage's entry emoji.recent to include an unlisted emoji name.
  2. Open a run with an enabled message box containing the emoji picker.

Expected behavior:

The room opens without errors; the invalid emoji is not listed in picker.

Actual behavior:

The whole room template fails to render.

Server Setup Information:

  • Version of Rocket.Chat Server: 1.1.0-develop (7ad3f25)
  • Operating System: Ubuntu 18.04.2
  • Deployment Method: from source code
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: 8.11.4 - x64
  • MongoDB Version: 4.0.2

Relevant logs:

TypeError: Cannot read property 'emojiPackage' of undefined
    at Object.renderPicker (http://localhost:3000/app/app.js?hash=dd8ce6fd29508ea122276b8b62d4c23814560481:88541:58)
    at http://localhost:3000/app/app.js?hash=dd8ce6fd29508ea122276b8b62d4c23814560481:88176:52
    at Array.map (<anonymous>)
    at http://localhost:3000/app/app.js?hash=dd8ce6fd29508ea122276b8b62d4c23814560481:88174:52
    at Array.map (<anonymous>)
    at createEmojiList (http://localhost:3000/app/app.js?hash=dd8ce6fd29508ea122276b8b62d4c23814560481:88169:46)
    at http://localhost:3000/app/app.js?hash=dd8ce6fd29508ea122276b8b62d4c23814560481:88189:72
    at Array.forEach (<anonymous>)
    at createPickerEmojis (http://localhost:3000/app/app.js?hash=dd8ce6fd29508ea122276b8b62d4c23814560481:88189:14)
    at Blaze.TemplateInstance.<anonymous> (http://localhost:3000/app/app.js?hash=dd8ce6fd29508ea122276b8b62d4c23814560481:88427:3) undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants