[IMPROVE] Added MaxNickNameLength and MaxBioLength constants (#25231)

* Added MaxNickNameLength and MaxBioLength constants added above mentioned constants to remove magic numbers in a simple manner * code style fixes Co-authored-by: gabriellsh <[email protected]>
RocketChat · Apr 19, 2022 · 15f55fd · 15f55fd
1 parent e419108
commit 15f55fd
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/apps/meteor/app/lib/server/functions/saveUser.js b/apps/meteor/app/lib/server/functions/saveUser.js
@@ -15,6 +15,9 @@ import { checkEmailAvailability, checkUsernameAvailability, setUserAvatar, setEm
 import { Users } from '../../../models/server';
 import { callbacks } from '../../../../lib/callbacks';
 
+const MAX_BIO_LENGTH = 260;
+const MAX_NICKNAME_LENGTH = 120;
+
 let html = '';
 let passwordChangedHtml = '';
 Meteor.startup(() => {
@@ -228,7 +231,7 @@ export function validateUserEditing(userId, userData) {
 
 const handleBio = (updateUser, bio) => {
 	if (bio && bio.trim()) {
-		if (typeof bio !== 'string' || bio.length > 260) {
+		if (typeof bio !== 'string' || bio.length > MAX_BIO_LENGTH) {
 			throw new Meteor.Error('error-invalid-field', 'bio', {
 				method: 'saveUserProfile',
 			});
@@ -243,7 +246,7 @@ const handleBio = (updateUser, bio) => {
 
 const handleNickname = (updateUser, nickname) => {
 	if (nickname && nickname.trim()) {
-		if (typeof nickname !== 'string' || nickname.length > 120) {
+		if (typeof nickname !== 'string' || nickname.length > MAX_NICKNAME_LENGTH) {
 			throw new Meteor.Error('error-invalid-field', 'nickname', {
 				method: 'saveUserProfile',
 			});