-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: jump to message fails on Files (messagesView) #7601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OtavioStasiak
wants to merge
5
commits into
develop
Choose a base branch
from
fix.jump-to-message-fails-on-file
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43
−4
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b49464c
feat: implement endpoint to get the messageId
OtavioStasiak 7af2c30
chore: format code and fix lint issues
OtavioStasiak 61a4a59
cleanup
OtavioStasiak 253d215
cleanup
OtavioStasiak e34ed65
Merge branch 'develop' into fix.jump-to-message-fails-on-file
OtavioStasiak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,7 +31,15 @@ import { | |
| type TAnyMessageModel, | ||
| type IUrl | ||
| } from '../../definitions'; | ||
| import { getFiles, getMessages, getPinnedMessages, togglePinMessage, toggleStarMessage } from '../../lib/services/restApi'; | ||
| import { | ||
| getFiles, | ||
| getMessageByFileId, | ||
| getMessages, | ||
| getPinnedMessages, | ||
| togglePinMessage, | ||
| toggleStarMessage | ||
| } from '../../lib/services/restApi'; | ||
| import { compareServerVersion, showErrorAlert } from '../../lib/methods/helpers'; | ||
| import { type TNavigation } from '../../stacks/stackType'; | ||
| import AudioManager from '../../lib/methods/AudioManager'; | ||
| import { Encryption } from '../../lib/encryption'; | ||
|
|
@@ -54,6 +62,7 @@ interface IMessagesViewProps { | |
| showActionSheet: (params: { options: string[]; hasCancel: boolean }) => void; | ||
| isMasterDetail: boolean; | ||
| insets: EdgeInsets; | ||
| serverVersion: string | null; | ||
| } | ||
|
|
||
| interface IMessagesViewState { | ||
|
|
@@ -136,11 +145,31 @@ class MessagesView extends Component<IMessagesViewProps, IMessagesViewState> { | |
| navigation.navigate('RoomInfoView', navParam); | ||
| }; | ||
|
|
||
| resolveMessageId = async (item: IMessage): Promise<string | null> => { | ||
| const { route, serverVersion } = this.props; | ||
| if (route.params?.name !== 'Files' || compareServerVersion(serverVersion, 'lowerThan', '8.9.0')) { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a gap that makes 8.9.* call the new logic, but your comment on the other file says 8.10.0. |
||
| return item._id; | ||
|
OtavioStasiak marked this conversation as resolved.
|
||
| } | ||
|
|
||
| try { | ||
| const result = await getMessageByFileId(item._id); | ||
| if (result.success && result.message) { | ||
| return result.message._id; | ||
| } | ||
| } catch {} | ||
| return null; | ||
| }; | ||
|
|
||
| jumpToMessage = async ({ item }: { item: IMessage }) => { | ||
| const { isMasterDetail } = this.props; | ||
| const jumpToMessageId = await this.resolveMessageId(item); | ||
| if (!jumpToMessageId) { | ||
| showErrorAlert(I18n.t('Message_not_found'), I18n.t('Oops')); | ||
| return; | ||
| } | ||
| let params: IParams = { | ||
| rid: this.rid, | ||
| jumpToMessageId: item._id, | ||
| jumpToMessageId, | ||
| t: this.t, | ||
| room: this.room | ||
| }; | ||
|
|
@@ -149,7 +178,7 @@ class MessagesView extends Component<IMessagesViewProps, IMessagesViewState> { | |
| params = { | ||
| ...params, | ||
| tmid: item.tmid, | ||
| name: await getThreadName(this.rid, item.tmid, item._id), | ||
| name: await getThreadName(this.rid, item.tmid, jumpToMessageId), | ||
| t: SubscriptionType.THREAD | ||
| }; | ||
| Navigation.push('RoomView', params); | ||
|
|
@@ -367,7 +396,8 @@ class MessagesView extends Component<IMessagesViewProps, IMessagesViewState> { | |
|
|
||
| const mapStateToProps = (state: IApplicationState) => ({ | ||
| baseUrl: state.server.server, | ||
| user: getUserSelector(state) | ||
| user: getUserSelector(state), | ||
| serverVersion: state.server.version | ||
| }); | ||
|
|
||
| export default connect(mapStateToProps)(withTheme(withActionSheet(withMasterDetail(withSafeAreaInsets(MessagesView))))); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to wait the backend PR to merge so we're sure about the version