refactor: derive isMasterDetail per-component and remove Dimensions provider by diegolmello · Pull Request #7422 · RocketChat/Rocket.Chat.ReactNative

diegolmello · 2026-06-19T21:32:04Z

Proposed changes

The app tracked the master-detail layout flag through a root pipeline: Dimensions.addEventListener in app/index.tsx recomputed isMasterDetail on every window change, wrote it to state.app.isMasterDetail, and fed width/height/scale/fontScale into a DimensionsContext consumed app-wide. Every dimension change triggered a Redux dispatch plus a context update that re-rendered unrelated subtrees.

This removes that pipeline and derives the flag where it's used:

New useMasterDetail() hook computes isTablet && width > MIN_WIDTH_MASTER_DETAIL_LAYOUT from useWindowDimensions().
Function-component readers call the hook directly.
Class components receive the flag via a withMasterDetail HOC in their connect chain (and the three views that needed raw dimensions move to a hook-backed withDimensions).
Non-React callers (sagas) read a synchronous getIsMasterDetail() snapshot from Dimensions.get('window'), since hooks can't run there.
Deleted state.app.isMasterDetail (field, action, reducer case), the root Dimensions listener, and app/dimensions.tsx.

The flag now reacts to window resize directly instead of a debounced Redux round-trip, and dimension changes no longer fan out through a global context.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-886

How to test or reproduce

Tablet (or split view): rotate / resize across the 700px master-detail threshold and confirm the layout switches between MasterDetailStack and InsideStack as before.
Phone: confirm single-stack layout is unchanged.
Exercise screens that branch on master-detail (RoomView, RoomActionsView, RoomsListView, ProfileView, directory/new-message flows) and confirm navigation targets the correct pane.

Types of changes

Improvement (non-breaking change which improves a current function)

Checklist

I have read the CONTRIBUTING doc
I have signed the CLA
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if applicable)

Further comments

IBaseScreen.isMasterDetail is kept — it's the prop the HOC injects into class screens, distinct from the removed Redux field.

Summary by CodeRabbit

Refactor
- Switched master/detail mode to a shared, device-width–based evaluation via a hook, with optional HOC injection across headers, views, notifications, and navigation flows.
- Removed master/detail from Redux state, related action types, and updated saga navigation logic to use the shared getter.
- Removed the old dimensions context, and introduced a hook-based bridge for class-style components.
- Simplified some app components by moving away from Redux connect where applicable.
Bug Fixes
- Prevented stale master/detail decisions by eliminating Redux-driven updates.
Tests
- Updated mocks and removed reducer coverage tied to the removed master/detail action.

useMasterDetail derives the master-detail flag per-component from useWindowDimensions, replacing the Redux state.app.isMasterDetail field. withMasterDetail/withDimensions bridge the hooks into class components, injecting the values as props and stripping them from the public prop type. Claude-Session: https://claude.ai/code/session_01G1Y1nFCGsaMDy5XaYYmGhX

Remove the root Dimensions.addEventListener -> setState pipeline in app/index.tsx and the DimensionsContext it fed, along with the Redux state.app.isMasterDetail field, its action, and reducer case. Every reader now derives the flag locally: function components call useMasterDetail(); class components receive it via the withMasterDetail HOC in their connect chain. The three views that consumed dimension props move to the hook-backed withDimensions. Delete app/dimensions.tsx; its only remaining consumer (List stories) drives fontScale through ResponsiveLayoutContext. The flag now tracks window resize directly instead of a debounced Redux round-trip, so split-view changes on tablets apply without a store update. Claude-Session: https://claude.ai/code/session_01G1Y1nFCGsaMDy5XaYYmGhX

coderabbitai · 2026-06-19T21:32:20Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e4f75559-e3e4-4905-b862-9b5833f790e0

📥 Commits

Reviewing files that changed from the base of the PR and between 8472dfa and d732324.

📒 Files selected for processing (5)

app/containers/RoomHeader/RoomHeader.tsx
app/views/RoomActionsView/index.tsx
app/views/RoomInfoView/index.tsx
app/views/RoomView/index.tsx
app/views/StatusView/index.tsx

🚧 Files skipped from review as they are similar to previous changes (5)

app/views/StatusView/index.tsx
app/containers/RoomHeader/RoomHeader.tsx
app/views/RoomView/index.tsx
app/views/RoomInfoView/index.tsx
app/views/RoomActionsView/index.tsx

📜 Recent review details

⏰ Context from checks skipped due to timeout. (1)

GitHub Check: ESLint and Test / run-eslint-and-test

Walkthrough

Introduces useMasterDetail hook and withMasterDetail/withDimensions HOCs in app/lib/hooks/. Removes isMasterDetail from Redux IApp state, ISetMasterDetail action, and SET_MASTER_DETAIL action type. Removes DimensionsContext from app root. Migrates ~50 consumers across views, containers, and sagas to the hook or HOC pattern.

Changes

isMasterDetail Redux-to-hook migration

Layer / File(s)	Summary
New `useMasterDetail` and `withDimensions` hooks/HOCs `app/lib/hooks/useMasterDetail.tsx`, `app/lib/hooks/withDimensions.tsx`	`useMasterDetail` computes a boolean from `isTablet` and window width vs `MIN_WIDTH_MASTER_DETAIL_LAYOUT`. `getIsMasterDetail` provides a non-hook variant for sagas. `withMasterDetail` HOC injects that value and hoists statics. `withDimensions` HOC injects `useWindowDimensions` fields and hoists statics.
Remove `isMasterDetail` from Redux actions and reducer `app/actions/actionsTypes.ts`, `app/actions/app.ts`, `app/reducers/app.ts`, `app/reducers/app.test.ts`, `app/views/ProfileView/index.test.tsx`	Removes `SET_MASTER_DETAIL` action type, `ISetMasterDetail` interface, `setMasterDetail` action creator, `isMasterDetail` field from `IApp` and `initialState`, the corresponding reducer case, and unit tests.
Remove `DimensionsContext` from app root `app/index.tsx`, `app/containers/List/List.stories.tsx`	`Root`'s `IState` loses dimension fields; constructor drops `Dimensions` reads and tablet setup; `render()` removes the `DimensionsContext.Provider` wrapper. `List.stories.tsx` switches `FontStory` from `DimensionsContext.Provider` to `ResponsiveLayoutContext.Provider`.
Functional components migrated to `useMasterDetail` hook `app/AppContainer.tsx`, `app/containers/Header/index.tsx`, `app/containers/InAppNotification/...`, `app/containers/MediaCallHeader/components/Content.tsx`, `app/containers/MessageComposer/components/...`, `app/containers/TwoFactor/index.tsx`, `app/containers/RoomHeader/RoomHeader.tsx`, `app/containers/markdown/components/mentions/Hashtag.tsx`, `app/ee/omnichannel/...`, `app/views/...` (~37 files)	All functional component consumers replace `useAppSelector(state => state.app.isMasterDetail)` with a direct `useMasterDetail()` call; Redux selectors narrowed to exclude layout state.
Connected components and class views migrated to `withMasterDetail` HOC `app/containers/InAppNotification/NotifierComponent.tsx`, `app/containers/MessageActions/index.tsx`, `app/views/MessagesView/index.tsx`, `app/views/RoomView/JoinCode.tsx`, `app/views/RoomView/RightButtons.tsx`, `app/views/RoomView/index.tsx`, `app/views/RoomActionsView/index.tsx`, `app/views/SearchMessagesView/index.tsx`, `app/views/SelectListView.tsx`, `app/views/TeamChannelsView.tsx`, `app/views/ThreadMessagesView/index.tsx` (~11 files)	`mapStateToProps` no longer provides `isMasterDetail`; components are wrapped with `withMasterDetail` in their default export HOC chain. `withDimensions` import paths updated in `RoomActionsView`, `RoomView`, and `TeamChannelsView`.
Sagas migrated to use `getIsMasterDetail` helper `app/sagas/createChannel.js`, `app/sagas/deepLinking.js`, `app/sagas/login.js`, `app/sagas/messages.js`, `app/sagas/room.js`	Sagas replace `yield select(state => state.app.isMasterDetail)` with synchronous `getIsMasterDetail()` calls; `redux-saga`'s `select` effect import removed where no longer used.

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

RocketChat/Rocket.Chat.ReactNative#7229: Both PRs modify app/containers/MessageActions/index.tsx—the main PR changes MessageActions HOC wiring to inject isMasterDetail via withMasterDetail, while the retrieved PR adds accessibility focus/announce behavior when the message action sheet closes—so they overlap at the same module code level.

Suggested reviewers

OtavioStasiak

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately and concisely describes the main refactoring objective: moving isMasterDetail derivation to components and eliminating the global Dimensions provider.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 OSV Scanner (2.4.0)

Error: ENOENT: no such file or directory, scandir '/inmem/1292/nsjail-195e8c58-6fc3-4e5c-8026-177bbc1c3b10/merged/node_modules/bare-stream'

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

NATIVE-886: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

connect(..., { forwardRef: true }) wraps forwardRef screens (MessageActions, JoinCode) whose parents hold a ref and call imperative methods. The HOC sat between connect and the component as a plain function component, swallowing the ref. Make both HOCs forwardRef so the ref reaches the wrapped component. Claude-Session: https://claude.ai/code/session_01G1Y1nFCGsaMDy5XaYYmGhX

…ield Sagas can't call the useMasterDetail hook, and the Redux state.app.isMasterDetail field no longer exists. Add getIsMasterDetail(), a synchronous snapshot from Dimensions.get('window'), and use it in the createChannel, deepLinking, login, room, and messages sagas so master-detail navigation keeps working. Claude-Session: https://claude.ai/code/session_01G1Y1nFCGsaMDy5XaYYmGhX

diegolmello · 2026-06-19T21:42:01Z

Review summary

Reviewed the full diff (≈50 readers migrated, 2 HOCs added, root pipeline + app/dimensions.tsx removed). tsc --noEmit clean, ESLint clean (only pre-existing React-hooks/complexity warnings, none introduced here), TZ=UTC pnpm test 1615/1615 green.

Two correctness issues were found and fixed while reviewing:

1. Refs were swallowed by the new HOCs. withMasterDetail/withDimensions started as plain function components, so a parent's ref never reached the wrapped component. RoomView holds refs to MessageActions and JoinCode and calls imperative methods on them, so those refs would have been null. Fixed by making both HOCs use forwardRef and pass the ref through (and hoistNonReactStatics to preserve navigationOptions).

2. Five sagas still read the removed Redux field. createChannel, deepLinking, login, room, and messages read state.app.isMasterDetail, which now returns undefined — master-detail navigation (goRoom/navigateToRoom/popToTop) would silently get a falsy value. Sagas can't call the hook, so they now read a synchronous getIsMasterDetail() snapshot from Dimensions.get('window'). This is behaviorally equivalent to (slightly fresher than) the old debounced Redux value.

Nit

No dedicated unit test for useMasterDetail/the HOCs. Behavior is covered indirectly by existing view and reducer tests; a focused test would lock the threshold formula down but isn't blocking.

Otherwise the migration is consistent and the refactor preserves behavior. LGTM.

coderabbitai

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

app/views/AddExistingChannelView/index.tsx (1)

47-52: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Header options do not react to master-detail toggles.

isMasterDetail now changes with window width, but useLayoutEffect only depends on selected.length. Crossing the tablet threshold will not refresh headerLeft until selection changes.

Suggested fix

-	useLayoutEffect(() => {
-		setHeader();
-	}, [selected.length]);
+	useLayoutEffect(() => {
+		setHeader();
+	}, [selected.length, isMasterDetail, navigation]);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/views/AddExistingChannelView/index.tsx` around lines 47 - 52, The
useLayoutEffect hook that calls setHeader() only includes selected.length in its
dependency array, but the effect also depends on isMasterDetail which changes
when the window crosses the tablet threshold. Add isMasterDetail to the
dependency array of the useLayoutEffect hook so that setHeader() is properly
invoked whenever either selected.length or isMasterDetail changes, ensuring
header options update correctly during master-detail mode toggles.

🧹 Nitpick comments (2)

app/views/UserNotificationPreferencesView/index.tsx (1)

33-35: Select the primitive id directly to avoid unnecessary rerenders.

The current selector wraps the result in an object literal, creating a new reference on every store update. Since useAppSelector uses reference equality, this triggers rerenders even when the userId value hasn't changed. Select the primitive directly instead:

Suggested change

-	const { userId } = useAppSelector(state => ({
-		userId: getUserSelector(state).id
-	}));
+	const userId = useAppSelector(state => getUserSelector(state).id);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/views/UserNotificationPreferencesView/index.tsx` around lines 33 - 35,
The useAppSelector call in the UserNotificationPreferencesView is wrapping the
userId value in an object literal, which creates a new reference on every store
update even when the userId itself hasn't changed, triggering unnecessary
rerenders. Instead of selecting an object and destructuring it, modify the
selector to return the primitive id value directly by removing the object
wrapper and calling getUserSelector(state).id directly as the return value of
the useAppSelector callback, then assign it directly to userId without
destructuring.

app/views/SelectListView.tsx (1)

211-213: ⚡ Quick win

Avoid a no-op mapStateToProps subscription.

connect(() => ({})) subscribes this component to store updates without consuming state. Prefer connect(null) or remove connect entirely if no dispatch props are needed.

Proposed change

-const mapStateToProps = () => ({});
-
-export default connect(mapStateToProps)(withTheme(withMasterDetail(SelectListView)));
+export default withTheme(withMasterDetail(SelectListView));

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/views/SelectListView.tsx` around lines 211 - 213, The mapStateToProps
function in SelectListView is a no-op that returns an empty object and creates
an unnecessary Redux subscription. Replace the mapStateToProps function call in
the connect() invocation with null instead, by changing connect(mapStateToProps)
to connect(null), or remove the connect wrapper entirely if no dispatch props
are required. This eliminates the unnecessary store subscription and simplifies
the component definition.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/views/AccessibilityAndAppearanceView/index.tsx`:
- Line 25: The useLayoutEffect hook that sets up headerLeft needs to be updated
to respond to changes in the isMasterDetail value. Add isMasterDetail to the
dependency array of the useLayoutEffect hook (the one that configures the
navigation header options) so that the effect re-runs whenever the master-detail
mode changes due to resize, rotation, or other layout changes. This ensures that
headerLeft and other header options remain synchronized with the current
master-detail state.

In `@app/views/RoomsListView/components/TabletHeader.tsx`:
- Around line 8-13: In the TabletHeader component, replace the `any` type
parameters in the useNavigation and useRoute hooks with proper TypeScript types.
Import NativeStackNavigationProp and RouteProp from
`@react-navigation/native-stack` and MasterDetailInsideStackParamList from the
navigation types, then apply these types to the respective hooks. Additionally,
add an explicit return type annotation of ReactElement | null to the
TabletHeader function declaration to ensure proper type safety.

---

Outside diff comments:
In `@app/views/AddExistingChannelView/index.tsx`:
- Around line 47-52: The useLayoutEffect hook that calls setHeader() only
includes selected.length in its dependency array, but the effect also depends on
isMasterDetail which changes when the window crosses the tablet threshold. Add
isMasterDetail to the dependency array of the useLayoutEffect hook so that
setHeader() is properly invoked whenever either selected.length or
isMasterDetail changes, ensuring header options update correctly during
master-detail mode toggles.

---

Nitpick comments:
In `@app/views/SelectListView.tsx`:
- Around line 211-213: The mapStateToProps function in SelectListView is a no-op
that returns an empty object and creates an unnecessary Redux subscription.
Replace the mapStateToProps function call in the connect() invocation with null
instead, by changing connect(mapStateToProps) to connect(null), or remove the
connect wrapper entirely if no dispatch props are required. This eliminates the
unnecessary store subscription and simplifies the component definition.

In `@app/views/UserNotificationPreferencesView/index.tsx`:
- Around line 33-35: The useAppSelector call in the
UserNotificationPreferencesView is wrapping the userId value in an object
literal, which creates a new reference on every store update even when the
userId itself hasn't changed, triggering unnecessary rerenders. Instead of
selecting an object and destructuring it, modify the selector to return the
primitive id value directly by removing the object wrapper and calling
getUserSelector(state).id directly as the return value of the useAppSelector
callback, then assign it directly to userId without destructuring.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d1f6a55b-f099-4c25-9b69-77775209d6bd

📥 Commits

Reviewing files that changed from the base of the PR and between 6bbf88a and 687c68b.

📒 Files selected for processing (62)

app/AppContainer.tsx
app/actions/actionsTypes.ts
app/actions/app.ts
app/containers/Header/index.tsx
app/containers/InAppNotification/IncomingCallNotification/index.tsx
app/containers/InAppNotification/NotifierComponent.tsx
app/containers/List/List.stories.tsx
app/containers/MediaCallHeader/components/Content.tsx
app/containers/MessageActions/index.tsx
app/containers/MessageComposer/components/Buttons/ActionsButton.tsx
app/containers/MessageComposer/components/ComposerInput.tsx
app/containers/RoomHeader/RoomHeader.tsx
app/containers/TwoFactor/index.tsx
app/containers/markdown/components/mentions/Hashtag.tsx
app/dimensions.tsx
app/ee/omnichannel/containers/OmnichannelHeader/index.tsx
app/ee/omnichannel/views/QueueListView.tsx
app/index.tsx
app/lib/hooks/useMasterDetail.tsx
app/lib/hooks/withDimensions.tsx
app/reducers/app.test.ts
app/reducers/app.ts
app/views/AccessibilityAndAppearanceView/index.tsx
app/views/AddChannelTeamView.tsx
app/views/AddExistingChannelView/index.tsx
app/views/AdminPanelView/index.tsx
app/views/CallView/components/CallButtons.tsx
app/views/CannedResponseDetail.tsx
app/views/CannedResponsesListView/index.tsx
app/views/CloseLivechatView.tsx
app/views/CreateDiscussionView/index.tsx
app/views/DirectoryView/index.tsx
app/views/DiscussionsView/index.tsx
app/views/MessagesView/index.tsx
app/views/NewMessageView/index.tsx
app/views/NotificationPreferencesView/index.tsx
app/views/ProfileView/index.test.tsx
app/views/ProfileView/index.tsx
app/views/ReportUserView/index.tsx
app/views/RoomActionsView/index.tsx
app/views/RoomInfoView/index.tsx
app/views/RoomMembersView/index.tsx
app/views/RoomView/JoinCode.tsx
app/views/RoomView/RightButtons.tsx
app/views/RoomView/components/EncryptedRoom.tsx
app/views/RoomView/index.tsx
app/views/RoomsListView/components/ListHeader.tsx
app/views/RoomsListView/components/ServersList.tsx
app/views/RoomsListView/components/TabletHeader.tsx
app/views/RoomsListView/hooks/useHeader.tsx
app/views/RoomsListView/index.tsx
app/views/SearchMessagesView/index.tsx
app/views/SelectListView.tsx
app/views/SettingsView/index.tsx
app/views/SidebarView/components/Admin.tsx
app/views/SidebarView/components/Profile.tsx
app/views/SidebarView/components/Stacks.tsx
app/views/SidebarView/components/SupportedVersionsWarnItem.tsx
app/views/StatusView/index.tsx
app/views/TeamChannelsView.tsx
app/views/ThreadMessagesView/index.tsx
app/views/UserNotificationPreferencesView/index.tsx

💤 Files with no reviewable changes (3)

app/dimensions.tsx
app/reducers/app.ts
app/actions/actionsTypes.ts

📜 Review details

🧰 Additional context used

📓 Path-based instructions (9)

**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{js,ts,jsx,tsx}: Use descriptive names for functions, variables, and classes that clearly convey their purpose
Write comments that explain the 'why' behind code decisions, not the 'what'
Keep functions small and focused on a single responsibility
Use const by default, let when reassignment is needed, and avoid var
Prefer async/await over .then() chains for handling asynchronous operations
Use explicit error handling with try/catch blocks for async operations
Avoid deeply nested code; refactor complex logic into helper functions

Files:

app/containers/MediaCallHeader/components/Content.tsx
app/containers/Header/index.tsx
app/ee/omnichannel/containers/OmnichannelHeader/index.tsx
app/views/RoomsListView/components/TabletHeader.tsx
app/views/SidebarView/components/SupportedVersionsWarnItem.tsx
app/views/SelectListView.tsx
app/views/RoomsListView/components/ListHeader.tsx
app/views/NotificationPreferencesView/index.tsx
app/views/AddChannelTeamView.tsx
app/views/ProfileView/index.test.tsx
app/views/NewMessageView/index.tsx
app/lib/hooks/withDimensions.tsx
app/containers/InAppNotification/IncomingCallNotification/index.tsx
app/views/RoomsListView/components/ServersList.tsx
app/containers/MessageComposer/components/Buttons/ActionsButton.tsx
app/views/AccessibilityAndAppearanceView/index.tsx
app/ee/omnichannel/views/QueueListView.tsx
app/views/ReportUserView/index.tsx
app/containers/MessageComposer/components/ComposerInput.tsx
app/views/SidebarView/components/Profile.tsx
app/views/SettingsView/index.tsx
app/containers/TwoFactor/index.tsx
app/views/CloseLivechatView.tsx
app/views/CallView/components/CallButtons.tsx
app/views/StatusView/index.tsx
app/views/AdminPanelView/index.tsx
app/views/SearchMessagesView/index.tsx
app/containers/List/List.stories.tsx
app/views/RoomsListView/index.tsx
app/views/ProfileView/index.tsx
app/views/CannedResponsesListView/index.tsx
app/views/RoomView/JoinCode.tsx
app/lib/hooks/useMasterDetail.tsx
app/views/SidebarView/components/Admin.tsx
app/views/SidebarView/components/Stacks.tsx
app/AppContainer.tsx
app/views/RoomView/components/EncryptedRoom.tsx
app/reducers/app.test.ts
app/views/MessagesView/index.tsx
app/containers/markdown/components/mentions/Hashtag.tsx
app/containers/RoomHeader/RoomHeader.tsx
app/views/RoomMembersView/index.tsx
app/views/DiscussionsView/index.tsx
app/views/AddExistingChannelView/index.tsx
app/views/CannedResponseDetail.tsx
app/views/CreateDiscussionView/index.tsx
app/views/UserNotificationPreferencesView/index.tsx
app/views/RoomsListView/hooks/useHeader.tsx
app/containers/InAppNotification/NotifierComponent.tsx
app/views/RoomInfoView/index.tsx
app/views/RoomView/RightButtons.tsx
app/views/TeamChannelsView.tsx
app/views/DirectoryView/index.tsx
app/containers/MessageActions/index.tsx
app/views/RoomActionsView/index.tsx
app/views/RoomView/index.tsx
app/actions/app.ts
app/views/ThreadMessagesView/index.tsx
app/index.tsx

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx}: Use TypeScript for type safety; add explicit type annotations to function parameters and return types
Prefer interfaces over type aliases for defining object shapes in TypeScript
Use enums for sets of related constants rather than magic strings or numbers

Use TypeScript with strict mode enabled

Files:

app/containers/MediaCallHeader/components/Content.tsx
app/containers/Header/index.tsx
app/ee/omnichannel/containers/OmnichannelHeader/index.tsx
app/views/RoomsListView/components/TabletHeader.tsx
app/views/SidebarView/components/SupportedVersionsWarnItem.tsx
app/views/SelectListView.tsx
app/views/RoomsListView/components/ListHeader.tsx
app/views/NotificationPreferencesView/index.tsx
app/views/AddChannelTeamView.tsx
app/views/ProfileView/index.test.tsx
app/views/NewMessageView/index.tsx
app/lib/hooks/withDimensions.tsx
app/containers/InAppNotification/IncomingCallNotification/index.tsx
app/views/RoomsListView/components/ServersList.tsx
app/containers/MessageComposer/components/Buttons/ActionsButton.tsx
app/views/AccessibilityAndAppearanceView/index.tsx
app/ee/omnichannel/views/QueueListView.tsx
app/views/ReportUserView/index.tsx
app/containers/MessageComposer/components/ComposerInput.tsx
app/views/SidebarView/components/Profile.tsx
app/views/SettingsView/index.tsx
app/containers/TwoFactor/index.tsx
app/views/CloseLivechatView.tsx
app/views/CallView/components/CallButtons.tsx
app/views/StatusView/index.tsx
app/views/AdminPanelView/index.tsx
app/views/SearchMessagesView/index.tsx
app/containers/List/List.stories.tsx
app/views/RoomsListView/index.tsx
app/views/ProfileView/index.tsx
app/views/CannedResponsesListView/index.tsx
app/views/RoomView/JoinCode.tsx
app/lib/hooks/useMasterDetail.tsx
app/views/SidebarView/components/Admin.tsx
app/views/SidebarView/components/Stacks.tsx
app/AppContainer.tsx
app/views/RoomView/components/EncryptedRoom.tsx
app/reducers/app.test.ts
app/views/MessagesView/index.tsx
app/containers/markdown/components/mentions/Hashtag.tsx
app/containers/RoomHeader/RoomHeader.tsx
app/views/RoomMembersView/index.tsx
app/views/DiscussionsView/index.tsx
app/views/AddExistingChannelView/index.tsx
app/views/CannedResponseDetail.tsx
app/views/CreateDiscussionView/index.tsx
app/views/UserNotificationPreferencesView/index.tsx
app/views/RoomsListView/hooks/useHeader.tsx
app/containers/InAppNotification/NotifierComponent.tsx
app/views/RoomInfoView/index.tsx
app/views/RoomView/RightButtons.tsx
app/views/TeamChannelsView.tsx
app/views/DirectoryView/index.tsx
app/containers/MessageActions/index.tsx
app/views/RoomActionsView/index.tsx
app/views/RoomView/index.tsx
app/actions/app.ts
app/views/ThreadMessagesView/index.tsx
app/index.tsx

**/*.{js,jsx,ts,tsx,json}