fix: keep live socket on deeplink login (prevent orphan WebSocket clobber)

[diegolmello]

Proposed changes

Standalone fix extracted from #7311 (commit 29e4f8b).

Opening the app through an auth deeplink (and the call-push path) dispatched loginRequest before the WebSocket reached connected. The SDK login-guard then opened a second, orphaned socket. When the server later idle-timed-out the abandoned socket, its close flipped Redux to disconnected — so the app showed "Waiting for network" while a live, healthy socket still existed.

SDK patch (patches/@rocket.chat+sdk+1.3.3-mobile.patch, ddp driver)

• onClose now ignores close events from a socket that has already been replaced (compares identity against the current connection), so a zombie socket's late close can't clobber the live connection.
• open() tears down the previous connection's handlers and closes it before replacing it (mirrors forceReopen's teardown).

deepLinking saga (app/sagas/deepLinking.js)

• Before dispatching the resume loginRequest (auth-deeplink and call-push paths), gate on the socket being connected: after SERVER.SELECT_SUCCESS, read state.meteor.connected and only take(METEOR.SUCCESS) when still disconnected. This both prevents login on a still-connecting socket (the orphan-socket clobber) and can't hang the splash when the socket connects before SELECT_SUCCESS — METEOR.SUCCESS fires once and never refires, so an unconditional take would wait forever. handleOpen's already-connected fast path skips the wait entirely.

Issue(s)

NATIVE-1232 · related: NATIVE-1123

How to test or reproduce

1. Cold-start the app via an auth deeplink carrying a resume token (rocketchat://auth?...) for a workspace you are not currently connected to.
2. Before this fix: a second (orphan) socket opens; when the server idle-times-out the abandoned socket, the app falls to "Waiting for network" even though a live socket exists. After this fix: login waits for connected first, only one socket is ever opened, and no false "Waiting for network" appears.
3. Repeat via a call-push deeplink — same path, same expectation.
4. Unit test: TZ=UTC pnpm test --testPathPattern='app/sagas/__tests__/deepLinking.test' → 12/12 pass. Coverage now includes the connect-before-SELECT_SUCCESS ordering race, a gate assertion (no loginRequest until connected), and first-ever coverage for handleClickCallPush.

Screenshots

n/a

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Documentation update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable) — app/sagas/__tests__/deepLinking.test.ts
• I have added necessary documentation (if applicable) — inline comments next to each wait/guard
• Any dependent changes have been merged and published in downstream modules

Further comments

Cherry-picked from #7311 with git cherry-pick -x; the SDK-patch and saga changes apply cleanly. The handleOpen placement was adapted to develop's hostAlreadyConnected fast path (the wait sits inside the !hostAlreadyConnected branch). The wait was later hardened from an unconditional take(METEOR.SUCCESS) into a state.meteor.connected guard so a socket that connects before SELECT_SUCCESS can't make the saga block on a METEOR.SUCCESS that will never refire.

Summary by CodeRabbit

• Bug Fixes

  • Fixed cases where login proceeded before the socket was fully connected.
  • Improved reconnection handling with health-check probing and safer socket teardown to avoid stale-close interference and reduce false "Waiting for network" notices.

• New Features

  • Added support for media-signal and media-calls event types.

• Tests

  • Strengthened deep-linking tests to assert connection-before-login sequencing and race-order coverage.

[coderabbitai]

Walkthrough

Make deep-linking wait for the SDK socket to reach METEOR.SUCCESS before starting token-based login, refactor SDK Socket reconnection/teardown (probe/forceReopen, ignore orphan closes), and update deep-linking saga tests to simulate and assert the connected gating.

Changes

Connection State Sequencing for Deep Linking Authentication

Layer / File(s)	Summary
SDK socket connection management patches/@rocket.chat+sdk+1.3.3-mobile.patch	Socket now defensively tears down prior WebSockets, ignores orphan close events by passing the closed connection to onClose, adds probe() (ping/pong, 2s timeout), forceReopen() with synchronous disconnected/close emission and shared _reopenInFlight, and rewrites checkAndReopen() into an async freshness-bucketing flow. DDPDriver subscriptions add media-signal and media-calls.
Saga connection sequencing app/sagas/deepLinking.js	handleOpen and handleClickCallPush now await types.METEOR.SUCCESS after types.SERVER.SELECT_SUCCESS when a token is present and the host was not already connected, before dispatching loginRequest.
Test updates for connected gating app/sagas/__tests__/deepLinking.test.ts	Adds a Jest mock for ../../lib/database, imports connectSuccess and navigateToRoom, introduces setupRecordingStore to capture dispatched actions, dispatches connectSuccess()+microtask flush in multiple tests, and adds new tests for handleClickCallPush call-flow and race ordering.

Sequence Diagram

sequenceDiagram
  participant App as Deep Link Handler
  participant Saga as deepLinking saga
  participant Socket as SDK Socket

  App->>Saga: dispatch(SERVER.SELECT_SUCCESS)
  Saga->>Socket: await METEOR.SUCCESS
  Socket-->>Saga: emit METEOR.SUCCESS
  Saga->>App: dispatch(loginRequest)
  App->>Saga: dispatch(loginSuccess)

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• RocketChat/Rocket.Chat.ReactNative#7358: Also modifies app/sagas/deepLinking.js to adjust deep-link token auth sequencing relative to socket connection state.

Suggested reviewers

• OtavioStasiak
• Rohit3523

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: preventing orphan WebSocket from clobbering the live socket during deeplink login.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (2)

• NATIVE-1232: Request failed with status code 401
• NATIVE-1123: Request failed with status code 401

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

app/sagas/__tests__/deepLinking.test.ts (1)

205-216: ⚡ Quick win

The added connectSuccess() keeps the saga unblocked but doesn't actually verify the new METEOR.SUCCESS gating.

The saga parks at take(LOGIN.SUCCESS) after put(loginRequest), but take(LOGIN.SUCCESS) is satisfied directly by the test's loginSuccess() dispatch — it doesn't require loginRequest to have fired. So if the take(types.METEOR.SUCCESS) gating were removed from the saga, the connectSuccess() dispatch would become a harmless no-op and every one of these five tests would still pass. The behavior this PR introduces is therefore exercised but not asserted.

Consider adding an assertion that the saga stays parked before METEOR.SUCCESS — e.g. spy on store.dispatch (or assert via state) that loginRequest is not dispatched after selectServerSuccess but before connectSuccess(), then confirm it is dispatched after. That turns these into real regression tests for the orphan-socket fix.

This applies to all five regression tests (lines 208-211, 249-252, 286-289, 320-323, 360-363).

Want me to draft the dispatch spy assertions for one test so you can replicate across the five?

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/sagas/__tests__/deepLinking.test.ts` around lines 205 - 216, The test
currently dispatches selectServerSuccess then connectSuccess and finally
loginSuccess but never asserts that the saga's METEOR.SUCCESS gating actually
prevents loginRequest from being dispatched; update the test around
selectServerSuccess/connectSuccess/loginSuccess to spy on store.dispatch (e.g.,
jest.spyOn(store, 'dispatch') or mock the store dispatch) and assert that
loginRequest is NOT dispatched after selectServerSuccess and BEFORE
connectSuccess, then assert that loginRequest IS dispatched after you dispatch
connectSuccess (and before you call loginSuccess); reference the existing action
creators selectServerSuccess, connectSuccess, loginRequest, and loginSuccess
(and the saga's METEOR.SUCCESS gating) when adding these assertions and
replicate the same pattern for the other four tests mentioned.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@app/sagas/__tests__/deepLinking.test.ts`:
- Around line 205-216: The test currently dispatches selectServerSuccess then
connectSuccess and finally loginSuccess but never asserts that the saga's
METEOR.SUCCESS gating actually prevents loginRequest from being dispatched;
update the test around selectServerSuccess/connectSuccess/loginSuccess to spy on
store.dispatch (e.g., jest.spyOn(store, 'dispatch') or mock the store dispatch)
and assert that loginRequest is NOT dispatched after selectServerSuccess and
BEFORE connectSuccess, then assert that loginRequest IS dispatched after you
dispatch connectSuccess (and before you call loginSuccess); reference the
existing action creators selectServerSuccess, connectSuccess, loginRequest, and
loginSuccess (and the saga's METEOR.SUCCESS gating) when adding these assertions
and replicate the same pattern for the other four tests mentioned.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bf90b419-cd7f-42b1-8407-8a8b7687c90c

📥 Commits

Reviewing files that changed from the base of the PR and between acceba1 and 15aec04.

📒 Files selected for processing (2)

• app/sagas/__tests__/deepLinking.test.ts
• patches/@rocket.chat+sdk+1.3.3-mobile.patch

🚧 Files skipped from review as they are similar to previous changes (1)

• patches/@rocket.chat+sdk+1.3.3-mobile.patch

📜 Review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: ESLint and Test / run-eslint-and-test

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{js,ts,jsx,tsx}: Use descriptive names for functions, variables, and classes that clearly convey their purpose
Write comments that explain the 'why' behind code decisions, not the 'what'
Keep functions small and focused on a single responsibility
Use const by default, let when reassignment is needed, and avoid var
Prefer async/await over .then() chains for handling asynchronous operations
Use explicit error handling with try/catch blocks for async operations
Avoid deeply nested code; refactor complex logic into helper functions

Files:

• app/sagas/__tests__/deepLinking.test.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx}: Use TypeScript for type safety; add explicit type annotations to function parameters and return types
Prefer interfaces over type aliases for defining object shapes in TypeScript
Use enums for sets of related constants rather than magic strings or numbers

Use TypeScript with strict mode and baseUrl set to app/ for import resolution

Files:

• app/sagas/__tests__/deepLinking.test.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx,js,jsx}: Use Prettier with tabs, single quotes, 130 char width, no trailing commas, arrow parens avoid, bracket same line
Use @rocket.chat/eslint-config base with React, React Native, TypeScript, Jest plugins

Files:

• app/sagas/__tests__/deepLinking.test.ts

app/sagas/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Sagas for side effects should be placed in app/sagas/ directory (init, login, rooms, messages, encryption, deepLinking, videoConf)

Files:

• app/sagas/__tests__/deepLinking.test.ts

🧠 Learnings (4)

📓 Common learnings

Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7298
File: patches/@rocket.chat+sdk+1.3.3-mobile.patch:59-90
Timestamp: 2026-05-05T14:41:08.368Z
Learning: In `patches/rocket.chat+sdk+1.3.3-mobile.patch` (`rocket.chat/sdk` DDPDriver), `forceReopen()` intentionally sets `this.lastPing = 0` at teardown start. `Socket.onOpen` resets `this.lastPing = Date.now()` when the DDP connect handshake completes (inside `open()`), so `lastPing` is already fresh by the time `forceReopen()` resolves. Concurrent `checkAndReopen` calls during a reopen are handled by `_reopenInFlight`: the stale bucket routes them back into `forceReopen()`, which short-circuits via the in-flight promise guard — no double teardown. The design is intentionally self-healing and idempotent.

Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7298
File: patches/@rocket.chat+sdk+1.3.3-mobile.patch:79-79
Timestamp: 2026-05-05T21:08:50.423Z
Learning: When reviewing `.patch` files for the `rocket.chat/sdk` package (e.g., `patches/rocket.chat+sdk+1.3.3-mobile.patch`), the sandbox's `node_modules` reflects the **pre-patch** state. Symbols that are pre-existing in the SDK source (such as `userDisconnectCloseCode = 4000` at line 43 of `node_modules/rocket.chat/sdk/lib/drivers/ddp.ts`) will not be found by grep against `node_modules`, causing false-positive "undefined symbol" findings. Always account for this when reviewing patch files against SDK internals.

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-05-18T14:40:38.892Z
Learning: Applies to app/lib/services/sdk.ts : SDK for Rocket.Chat WebSocket real-time subscriptions should be in app/lib/services/sdk.ts

📚 Learning: 2026-05-18T14:40:38.892Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-05-18T14:40:38.892Z
Learning: Applies to app/sagas/**/*.{ts,tsx} : Sagas for side effects should be placed in app/sagas/ directory (init, login, rooms, messages, encryption, deepLinking, videoConf)

Applied to files:

• app/sagas/__tests__/deepLinking.test.ts

📚 Learning: 2026-05-18T14:40:38.892Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-05-18T14:40:38.892Z
Learning: Applies to app/lib/services/connect.ts : Server connection management should be in app/lib/services/connect.ts

Applied to files:

• app/sagas/__tests__/deepLinking.test.ts

📚 Learning: 2026-04-30T17:07:51.020Z

Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7274
File: app/lib/services/voip/MediaCallEvents.ts:0-0
Timestamp: 2026-04-30T17:07:51.020Z
Learning: In this Rocket.Chat React Native codebase, the ESLint rule `no-void: error` is enforced. When you see a promise returned from an async call that is not awaited (a “floating promise”), do not silence it with the `void somePromise()` pattern. Instead, handle the promise explicitly by attaching `.catch(...)` (or otherwise awaiting/handling the error) so unhandled-rejection risks are addressed in a way that satisfies the existing ESLint configuration.

Applied to files:

• app/sagas/__tests__/deepLinking.test.ts

🔇 Additional comments (2)

app/sagas/__tests__/deepLinking.test.ts (2)

90-90: LGTM!

---

414-453: LGTM!

Also applies to: 460-478

[coderabbitai]

🧹 Nitpick comments (1)

app/sagas/__tests__/deepLinking.test.ts (1)

563-584: 💤 Low value

Consider making this suite's mock setup self-contained.

This beforeEach resets only a subset of mocks and never pins sdk.current.client.host, so the suite implicitly relies on the prior describe's afterEach (Line 497) leaving host = '' and on the un-reset goRoom/canOpenRoom/waitForNavigationReady mocks. It works under top-to-bottom execution, but becomes order-dependent under .only/filtered runs or future reordering. Explicitly resetting the relevant mocks (or jest.resetAllMocks()) and asserting/setting host here would make the suite independent.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/sagas/__tests__/deepLinking.test.ts` around lines 563 - 584, The
beforeEach mock setup is incomplete and leaves the suite order-dependent; update
the beforeEach in this test file to make it self-contained by calling
jest.resetAllMocks() (or explicitly reset mocks for goRoom, canOpenRoom,
waitForNavigationReady) and by explicitly setting or asserting
sdk.current.client.host to the desired value (e.g., '' or a specific host) so
tests don't rely on prior describe teardown; ensure you still reapply the
intended UserPreferences.getString, getServerById, getServerInfo,
navigateToRoom, and database.active.get mocks after the reset so the rest of the
setup remains intact.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@app/sagas/__tests__/deepLinking.test.ts`:
- Around line 563-584: The beforeEach mock setup is incomplete and leaves the
suite order-dependent; update the beforeEach in this test file to make it
self-contained by calling jest.resetAllMocks() (or explicitly reset mocks for
goRoom, canOpenRoom, waitForNavigationReady) and by explicitly setting or
asserting sdk.current.client.host to the desired value (e.g., '' or a specific
host) so tests don't rely on prior describe teardown; ensure you still reapply
the intended UserPreferences.getString, getServerById, getServerInfo,
navigateToRoom, and database.active.get mocks after the reset so the rest of the
setup remains intact.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 746b4138-c1ec-4597-a179-222617db6e18

📥 Commits

Reviewing files that changed from the base of the PR and between fb39169 and 5e12854.

📒 Files selected for processing (2)

• app/sagas/__tests__/deepLinking.test.ts
• app/sagas/deepLinking.js

🚧 Files skipped from review as they are similar to previous changes (1)

• app/sagas/deepLinking.js

📜 Review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: ESLint and Test / run-eslint-and-test

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{js,ts,jsx,tsx}: Use descriptive names for functions, variables, and classes that clearly convey their purpose
Write comments that explain the 'why' behind code decisions, not the 'what'
Keep functions small and focused on a single responsibility
Use const by default, let when reassignment is needed, and avoid var
Prefer async/await over .then() chains for handling asynchronous operations
Use explicit error handling with try/catch blocks for async operations
Avoid deeply nested code; refactor complex logic into helper functions

Files:

• app/sagas/__tests__/deepLinking.test.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx}: Use TypeScript for type safety; add explicit type annotations to function parameters and return types
Prefer interfaces over type aliases for defining object shapes in TypeScript
Use enums for sets of related constants rather than magic strings or numbers

Use TypeScript with strict mode and baseUrl set to app/ for import resolution

Files:

• app/sagas/__tests__/deepLinking.test.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx,js,jsx}: Use Prettier with tabs, single quotes, 130 char width, no trailing commas, arrow parens avoid, bracket same line
Use @rocket.chat/eslint-config base with React, React Native, TypeScript, Jest plugins

Files:

• app/sagas/__tests__/deepLinking.test.ts

app/sagas/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Sagas for side effects should be placed in app/sagas/ directory (init, login, rooms, messages, encryption, deepLinking, videoConf)

Files:

• app/sagas/__tests__/deepLinking.test.ts

🧠 Learnings (8)

📓 Common learnings

Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7298
File: patches/@rocket.chat+sdk+1.3.3-mobile.patch:59-90
Timestamp: 2026-05-05T14:41:08.368Z
Learning: In `patches/rocket.chat+sdk+1.3.3-mobile.patch` (`rocket.chat/sdk` DDPDriver), `forceReopen()` intentionally sets `this.lastPing = 0` at teardown start. `Socket.onOpen` resets `this.lastPing = Date.now()` when the DDP connect handshake completes (inside `open()`), so `lastPing` is already fresh by the time `forceReopen()` resolves. Concurrent `checkAndReopen` calls during a reopen are handled by `_reopenInFlight`: the stale bucket routes them back into `forceReopen()`, which short-circuits via the in-flight promise guard — no double teardown. The design is intentionally self-healing and idempotent.

Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7298
File: patches/@rocket.chat+sdk+1.3.3-mobile.patch:79-79
Timestamp: 2026-05-05T21:08:50.423Z
Learning: When reviewing `.patch` files for the `rocket.chat/sdk` package (e.g., `patches/rocket.chat+sdk+1.3.3-mobile.patch`), the sandbox's `node_modules` reflects the **pre-patch** state. Symbols that are pre-existing in the SDK source (such as `userDisconnectCloseCode = 4000` at line 43 of `node_modules/rocket.chat/sdk/lib/drivers/ddp.ts`) will not be found by grep against `node_modules`, causing false-positive "undefined symbol" findings. Always account for this when reviewing patch files against SDK internals.

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-05-18T14:40:38.892Z
Learning: Applies to app/lib/services/sdk.ts : SDK for Rocket.Chat WebSocket real-time subscriptions should be in app/lib/services/sdk.ts

📚 Learning: 2026-05-18T14:40:38.892Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-05-18T14:40:38.892Z
Learning: Applies to app/sagas/**/*.{ts,tsx} : Sagas for side effects should be placed in app/sagas/ directory (init, login, rooms, messages, encryption, deepLinking, videoConf)

Applied to files:

• app/sagas/__tests__/deepLinking.test.ts

📚 Learning: 2026-05-18T14:40:38.892Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-05-18T14:40:38.892Z
Learning: Applies to app/lib/store/**/*.{ts,tsx} : Store configuration should include middleware (saga, app state, internet state) and be placed in app/lib/store/

Applied to files:

• app/sagas/__tests__/deepLinking.test.ts

📚 Learning: 2026-05-18T14:40:38.892Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-05-18T14:40:38.892Z
Learning: Applies to app/lib/services/connect.ts : Server connection management should be in app/lib/services/connect.ts

Applied to files:

• app/sagas/__tests__/deepLinking.test.ts

📚 Learning: 2026-05-18T14:40:38.892Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-05-18T14:40:38.892Z
Learning: Applies to app/sagas/videoConf.ts : VideoConf feature should be implemented via Redux actions/reducers/sagas in app/sagas/videoConf.ts and app/lib/methods/videoConf.ts

Applied to files:

• app/sagas/__tests__/deepLinking.test.ts

📚 Learning: 2026-05-18T14:40:38.892Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-05-18T14:40:38.892Z
Learning: Applies to app/index.tsx : Redux provider, theme, navigation, and notifications setup should be in app/index.tsx

Applied to files:

• app/sagas/__tests__/deepLinking.test.ts

📚 Learning: 2026-05-18T14:40:38.892Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-05-18T14:40:38.892Z
Learning: Applies to app/reducers/**/*.{ts,tsx} : Reducers should be placed in app/reducers/ directory and manage state shape (app, login, connect, rooms, encryption, etc.)

Applied to files:

• app/sagas/__tests__/deepLinking.test.ts

📚 Learning: 2026-04-30T17:07:51.020Z

Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7274
File: app/lib/services/voip/MediaCallEvents.ts:0-0
Timestamp: 2026-04-30T17:07:51.020Z
Learning: In this Rocket.Chat React Native codebase, the ESLint rule `no-void: error` is enforced. When you see a promise returned from an async call that is not awaited (a “floating promise”), do not silence it with the `void somePromise()` pattern. Instead, handle the promise explicitly by attaching `.catch(...)` (or otherwise awaiting/handling the error) so unhandled-rejection risks are addressed in a way that satisfies the existing ESLint configuration.

Applied to files:

• app/sagas/__tests__/deepLinking.test.ts

🔇 Additional comments (4)

app/sagas/__tests__/deepLinking.test.ts (4)

50-59: LGTM!

---

134-145: LGTM!

---

258-306: LGTM!

---

590-661: LGTM!