Repository navigation
fix: resolve deep links by room id for channels and groups #7111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
b0c8994
use getRoomByTypeAndName to get more info
Rohit3523 76c5ec9
Merge branch 'develop' into private-channel-deeplink-fail
Rohit3523 32ea305
improve
Rohit3523 1af2c27
chore: format code and fix lint issues
Rohit3523 252c6b2
Added E2E test
Rohit3523 2f3c851
Merge branch 'private-channel-deeplink-fail' of https://github.com/Ro…
Rohit3523 4607327
chore: format code and fix lint issues
Rohit3523 180d1b8
Move group link to assorted
Rohit3523 97fc070
Merge branch 'private-channel-deeplink-fail' of https://github.com/Ro…
Rohit3523 9d42eca
update
Rohit3523 9e73065
Merge branch 'develop' into private-channel-deeplink-fail
Rohit3523 e2caede
Merge branch 'develop' into private-channel-deeplink-fail
Rohit3523 ceb8a17
Added typing for groups.open
Rohit3523 6fa65c4
remove ts-ignore
Rohit3523 b62c0dc
added test
Rohit3523 8e8e55f
chore: format code and fix lint issues
Rohit3523 198b39c
Merge branch 'develop' into private-channel-deeplink-fail
Rohit3523 f059b8f
using getinfo for channel too
Rohit3523 2d1a8f0
Merge branch 'develop' into private-channel-deeplink-fail
Rohit3523 01c8598
test update
Rohit3523 f27c93c
rerun ci
Rohit3523 3ef413e
revert
Rohit3523 a992162
Merge branch 'develop' into private-channel-deeplink-fail
OtavioStasiak 86e45ac
Merge branch 'develop' into private-channel-deeplink-fail
OtavioStasiak 1a2b919
Merge branch 'develop' into private-channel-deeplink-fail
Rohit3523 7140ddb
added deeplink test in sniffler
Rohit3523 5da8ebf
create channel and group using test account
Rohit3523 af98bc4
test fix
Rohit3523 387ec21
Merge branch 'develop' into private-channel-deeplink-fail
Rohit3523 bcfc461
chore: format code and fix lint issues
Rohit3523 84ac63a
improve code
Rohit3523 1441239
Merge branch 'develop' into private-channel-deeplink-fail
Rohit3523 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| appId: chat.rocket.reactnative | ||
| name: Group Deeplink | ||
| onFlowStart: | ||
| - runFlow: '../../helpers/setup.yaml' | ||
| tags: | ||
| - test-12 | ||
|
|
||
| --- | ||
| - runFlow: | ||
| file: '../../helpers/login-with-deeplink.yaml' | ||
| env: | ||
| USERNAME: ${output.account.adminUser} | ||
| PASSWORD: ${output.account.adminPassword} | ||
|
|
||
| # open group using name | ||
| - killApp | ||
| - runFlow: | ||
| file: '../../helpers/open-deeplink.yaml' | ||
| env: | ||
| link: 'https://go.rocket.chat/room?host=mobile.qa.rocket.chat&path=group/4t6Mw3K4M9JLeHuCH' | ||
| - extendedWaitUntil: | ||
| visible: 'discussion-with-name' | ||
| timeout: 60000 | ||
|
|
||
| # open group using name | ||
| - killApp | ||
| - runFlow: | ||
| file: '../../helpers/open-deeplink.yaml' | ||
| env: | ||
| link: 'https://go.rocket.chat/room?host=mobile.qa.rocket.chat&path=group/69ea9d65395f71c85b3a38bc' | ||
|
Rohit3523 marked this conversation as resolved.
Outdated
|
||
| - extendedWaitUntil: | ||
| visible: 'discussion-with-id' | ||
| timeout: 60000 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.