Skip to content
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
b0c8994
use getRoomByTypeAndName to get more info
Rohit3523 Apr 7, 2026
76c5ec9
Merge branch 'develop' into private-channel-deeplink-fail
Rohit3523 Apr 23, 2026
32ea305
improve
Rohit3523 Apr 23, 2026
1af2c27
chore: format code and fix lint issues
Rohit3523 Apr 23, 2026
252c6b2
Added E2E test
Rohit3523 Apr 23, 2026
2f3c851
Merge branch 'private-channel-deeplink-fail' of https://github.com/Ro…
Rohit3523 Apr 23, 2026
4607327
chore: format code and fix lint issues
Rohit3523 Apr 23, 2026
180d1b8
Move group link to assorted
Rohit3523 Apr 25, 2026
97fc070
Merge branch 'private-channel-deeplink-fail' of https://github.com/Ro…
Rohit3523 Apr 25, 2026
9d42eca
update
Rohit3523 Apr 25, 2026
9e73065
Merge branch 'develop' into private-channel-deeplink-fail
Rohit3523 Apr 27, 2026
e2caede
Merge branch 'develop' into private-channel-deeplink-fail
Rohit3523 Jul 29, 2026
ceb8a17
Added typing for groups.open
Rohit3523 Jul 29, 2026
6fa65c4
remove ts-ignore
Rohit3523 Jul 29, 2026
b62c0dc
added test
Rohit3523 Jul 29, 2026
8e8e55f
chore: format code and fix lint issues
Rohit3523 Jul 29, 2026
198b39c
Merge branch 'develop' into private-channel-deeplink-fail
Rohit3523 Aug 3, 2026
f059b8f
using getinfo for channel too
Rohit3523 Aug 4, 2026
2d1a8f0
Merge branch 'develop' into private-channel-deeplink-fail
Rohit3523 Aug 6, 2026
01c8598
test update
Rohit3523 Aug 6, 2026
f27c93c
rerun ci
Rohit3523 Aug 6, 2026
3ef413e
revert
Rohit3523 Aug 6, 2026
a992162
Merge branch 'develop' into private-channel-deeplink-fail
OtavioStasiak Aug 12, 2026
86e45ac
Merge branch 'develop' into private-channel-deeplink-fail
OtavioStasiak Aug 12, 2026
1a2b919
Merge branch 'develop' into private-channel-deeplink-fail
Rohit3523 Aug 13, 2026
7140ddb
added deeplink test in sniffler
Rohit3523 Aug 13, 2026
5da8ebf
create channel and group using test account
Rohit3523 Aug 13, 2026
af98bc4
test fix
Rohit3523 Aug 13, 2026
387ec21
Merge branch 'develop' into private-channel-deeplink-fail
Rohit3523 Aug 19, 2026
bcfc461
chore: format code and fix lint issues
Rohit3523 Aug 19, 2026
84ac63a
improve code
Rohit3523 Aug 19, 2026
1441239
Merge branch 'develop' into private-channel-deeplink-fail
Rohit3523 Aug 20, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions .maestro/tests/assorted/group-deeplink.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
appId: chat.rocket.reactnative
name: Group Deeplink
onFlowStart:
- runFlow: '../../helpers/setup.yaml'
tags:
- test-12

---
- runFlow:
file: '../../helpers/login-with-deeplink.yaml'
env:
USERNAME: ${output.account.adminUser}
PASSWORD: ${output.account.adminPassword}

# open group using name
- killApp
- runFlow:
file: '../../helpers/open-deeplink.yaml'
env:
link: 'https://go.rocket.chat/room?host=mobile.qa.rocket.chat&path=group/4t6Mw3K4M9JLeHuCH'
- extendedWaitUntil:
visible: 'discussion-with-name'
timeout: 60000
Comment thread
Rohit3523 marked this conversation as resolved.
Outdated

# open group using name
- killApp
- runFlow:
file: '../../helpers/open-deeplink.yaml'
env:
link: 'https://go.rocket.chat/room?host=mobile.qa.rocket.chat&path=group/69ea9d65395f71c85b3a38bc'
Comment thread
Rohit3523 marked this conversation as resolved.
Outdated
- extendedWaitUntil:
visible: 'discussion-with-id'
timeout: 60000
13 changes: 10 additions & 3 deletions app/lib/methods/canOpenRoom.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ERoomTypes } from '../../definitions';
import database from '../database';
import sdk from '../services/sdk';
import { createDirectMessage } from '../services/restApi';
import { createDirectMessage, getRoomByTypeAndName } from '../services/restApi';

const restTypes = {
channel: 'channels',
Expand Down Expand Up @@ -29,10 +29,17 @@ async function open({ type, rid, name }: { type: ERoomTypes; rid: string; name:
// if it's a group we need to check if you can open
if (type === ERoomTypes.GROUP) {
try {
const response = await getRoomByTypeAndName('p', name);
// RC 0.61.0
// @ts-ignore
await sdk.post(`${restTypes[type]}.open`, params);
await sdk.post('groups.open', { roomId: response._id });

return {
...response,
rid: response._id
};
Comment thread
Rohit3523 marked this conversation as resolved.
Outdated
} catch (e: any) {
console.log('e', e);
Comment thread
Rohit3523 marked this conversation as resolved.
Outdated
if (!(e.data && /is already open/.test(e.data.error))) {
return false;
}
Expand All @@ -41,7 +48,7 @@ async function open({ type, rid, name }: { type: ERoomTypes; rid: string; name:

// if it's a channel or group and the link don't have rid
// we'll get info from the room
if ((type === ERoomTypes.CHANNEL || type === ERoomTypes.GROUP) && !rid) {
if (type === ERoomTypes.CHANNEL && !rid) {
// RC 0.72.0
// @ts-ignore
const result: any = await sdk.get(`${restTypes[type]}.info`, params);
Expand Down
Loading