Skip to content

fix(iOS): icon inside header button is not center aligned on iOS 26 #7105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rohit3523 merged 4 commits into from
Apr 7, 2026
Merged

fix(iOS): icon inside header button is not center aligned on iOS 26 #7105

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fddf2e6
get dynamic margin for header button
Rohit3523 Apr 6, 2026
cbe60c6
this time, i added support for ios 26 as well...
Rohit3523 Apr 6, 2026
42db67c
Merge branch 'develop' into header-button-fix
Rohit3523 Apr 7, 2026
76ee5e3
Merge branch 'develop' into header-button-fix
Rohit3523 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions app/containers/Header/components/HeaderButton/HeaderButtonContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import { type StyleProp, StyleSheet, View, type ViewProps, type ViewStyle } from 'react-native';
import { Platform, type StyleProp, StyleSheet, View, type ViewProps, type ViewStyle } from 'react-native';

import { isAndroid, isTablet } from '../../../../lib/methods/helpers/deviceInfo';
import { isAndroid, isIOS, isTablet } from '../../../../lib/methods/helpers/deviceInfo';

interface IHeaderButtonContainer {
children?: React.ReactElement | (React.ReactElement | null)[] | null;
Expand All @@ -10,18 +10,30 @@ interface IHeaderButtonContainer {
style?: StyleProp<ViewStyle>;
}

const getMargin = () => {
if (isTablet) {
return 5;
}
if (isIOS && Number(Platform.Version) > 26) {
return 0;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
}
return -5;
};

const margin = getMargin();

const styles = StyleSheet.create({
container: {
flexDirection: 'row',
alignItems: 'center',
justifyContent: 'center'
},
left: {
marginLeft: isTablet ? 5 : -5,
marginLeft: margin,
marginRight: isAndroid ? 5 : 0
},
right: {
marginRight: isTablet ? 5 : -5
marginRight: margin
}
});

Expand Down
Loading