Skip to content

fix(iOS): message press effect is not visible #7042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rohit3523 merged 9 commits into from
Mar 9, 2026
Merged

fix(iOS): message press effect is not visible #7042

Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7ec34dd
Using TouchableHighlight ;-;
Rohit3523 Mar 6, 2026
4ded7bf
chore: format code and fix lint issues
Rohit3523 Mar 6, 2026
a9a14dc
snapshot update
Rohit3523 Mar 6, 2026
87e5d2f
Added underlayColor prop
Rohit3523 Mar 6, 2026
36d02ea
using color value type
Rohit3523 Mar 6, 2026
00c3f9a
Using TouchableOpacity and removed opacity
Rohit3523 Mar 6, 2026
9218172
snapshot update
Rohit3523 Mar 6, 2026
d6aaaf7
remove unused prop
Rohit3523 Mar 6, 2026
7afebb8
Move Touchable from app/container to message and renamed it to Touch
Rohit3523 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/containers/Touchable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,9 @@ const Touchable = React.forwardRef<View, ITouchProps>(
marginStart,
marginTop
};
const androidProps = isIOS
const touchableProps = isIOS
? {}
: { background: TouchableNativeFeedback.Ripple(android_rippleColor ?? colors.surfaceNeutral, false) };
const touchableProps = isIOS ? { activeOpacity: 1 } : {};

return (
<Component
Expand All @@ -90,7 +89,6 @@ const Touchable = React.forwardRef<View, ITouchProps>(
style={[rectButtonStyle, marginStyles, { backgroundColor, borderRadius }]}
disabled={!enabled}
{...touchableProps}
{...androidProps}
{...props}>
<View
accessible={accessible}
Expand Down
Loading