Skip to content

fix: render mentions, emojis, and inline elements inside headings #6911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rohit3523 merged 48 commits into from
Aug 2, 2026
Merged

fix: render mentions, emojis, and inline elements inside headings #6911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
57a1402
Markdown rendering fix for user and channel mention
Rohit3523 Jan 11, 2026
5cecc0d
Added story
Rohit3523 Jan 11, 2026
cfb112b
Snapshot update
Rohit3523 Jan 11, 2026
0923428
Remove bold from mention
Rohit3523 Jan 15, 2026
196a500
chore: format code and fix lint issues [skip ci]
Rohit3523 Jan 15, 2026
61d8cee
Remove inlint style
Rohit3523 Jan 15, 2026
ab7bc37
chore: format code and fix lint issues [skip ci]
Rohit3523 Jan 15, 2026
e0246aa
Merge branch 'develop' into mention-markdown-fix
Rohit3523 Mar 15, 2026
936acf3
Added android style in mention
Rohit3523 Mar 15, 2026
c563b3a
snapshot update
Rohit3523 Mar 15, 2026
d09196b
It works with fontweight too ;-;
Rohit3523 Mar 15, 2026
6c7f366
Added italic mention in story
Rohit3523 Mar 15, 2026
9690ab2
Merge branch 'develop' into mention-markdown-fix
Rohit3523 Apr 23, 2026
9de47f3
use channels in story
Rohit3523 Apr 25, 2026
f1275c5
Merge branch 'develop' into mention-markdown-fix
Rohit3523 Apr 25, 2026
717c267
Merge branch 'develop' into mention-markdown-fix
Rohit3523 Jul 6, 2026
2cacce2
Changes
Rohit3523 Jul 6, 2026
8cad6f6
Readded style
Rohit3523 Jul 6, 2026
59a7020
story
Rohit3523 Jul 6, 2026
40757d0
fix
Rohit3523 Jul 6, 2026
4078c77
style readded for ios
Rohit3523 Jul 6, 2026
5f3d56b
test update
Rohit3523 Jul 6, 2026
a0111af
memorize it
Rohit3523 Jul 6, 2026
cb88c50
use textSemibold on android as well
Rohit3523 Jul 6, 2026
3aa3558
more changes
Rohit3523 Jul 7, 2026
bf01420
fix: add lineHeight to heading styles to prevent text clipping on iOS
Rohit3523 Jul 7, 2026
bf9559c
revert storybook change
Rohit3523 Jul 7, 2026
83a2f6c
chore: revert @rocket.chat/message-parser version bump (unrelated to …
Rohit3523 Jul 7, 2026
7b9a0f3
remove unrelated changes
Rohit3523 Jul 7, 2026
874183a
chore: bump @rocket.chat/message-parser to 0.31.36 (needed for nested…
Rohit3523 Jul 7, 2026
445892d
chore: update snapshot for new parser AST
Rohit3523 Jul 7, 2026
eb1c624
Improve markdown component by removing prop and using context inside …
Rohit3523 Jul 8, 2026
41f3d6c
Added inter italic font
Rohit3523 Jul 9, 2026
b7027e8
import fix
Rohit3523 Jul 9, 2026
57f1eff
some changes
Rohit3523 Jul 9, 2026
1bb821e
added bold too
Rohit3523 Jul 9, 2026
69056f6
chore: format code and fix lint issues
Rohit3523 Jul 9, 2026
9005abd
added provider in markdown context...
Rohit3523 Jul 9, 2026
e1af7da
Merge branch 'develop' into mention-markdown-fix
Rohit3523 Jul 9, 2026
01570c4
remove getCustomEmoji from story
Rohit3523 Jul 9, 2026
6c2406d
minor changes
Rohit3523 Jul 9, 2026
85dc3a0
Snapshot update
Rohit3523 Jul 9, 2026
3507337
Merge branch 'develop' into mention-markdown-fix
Rohit3523 Jul 29, 2026
22c035e
Merge branch 'develop' into mention-markdown-fix
Rohit3523 Jul 29, 2026
96f8a27
Improvements
Rohit3523 Jul 29, 2026
69b6218
story update
Rohit3523 Jul 29, 2026
e1de8ba
remove italic changes as well
Rohit3523 Jul 29, 2026
9a7a342
Merge branch 'develop' into mention-markdown-fix
Rohit3523 Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added android/app/src/main/assets/fonts/Inter-Bold_italic.otf
View file
Open in desktop
Binary file not shown.
Binary file added android/app/src/main/assets/fonts/Inter-Medium_italic.otf
View file
Open in desktop
Binary file not shown.
Binary file added android/app/src/main/assets/fonts/Inter-Regular_italic.otf
View file
Open in desktop
Binary file not shown.
Binary file added android/app/src/main/assets/fonts/Inter-SemiBold_italic.otf
View file
Open in desktop
Comment thread
Rohit3523 marked this conversation as resolved.
Binary file not shown.
322 changes: 253 additions & 69 deletions app/containers/UIKit/__snapshots__/UiKitMessage.test.tsx.snap
View file
Open in desktop

Large diffs are not rendered by default.

224 changes: 176 additions & 48 deletions app/containers/UIKit/__snapshots__/UiKitModal.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,9 +883,17 @@ exports[`Story Snapshots: ModalActionsWithShowMore should match snapshot 1`] = `
{
"color": "#2F343D",
},
{
"fontSize": 14,
},
[
{
"fontSize": 14,
},
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontWeight": "700",
"textAlign": "left",
},
],
]
}
>
Expand Down Expand Up @@ -1774,9 +1782,17 @@ exports[`Story Snapshots: ModalActionsWithShowMore should match snapshot 1`] = `
{
"color": "#2F343D",
},
{
"fontSize": 14,
},
[
{
"fontSize": 14,
},
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontWeight": "700",
"textAlign": "left",
},
],
]
}
>
Expand Down Expand Up @@ -1825,9 +1841,17 @@ exports[`Story Snapshots: ModalActionsWithShowMore should match snapshot 1`] = `
{
"color": "#2F343D",
},
{
"fontSize": 14,
},
[
{
"fontSize": 14,
},
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontWeight": "700",
"textAlign": "left",
},
],
]
}
>
Expand Down Expand Up @@ -3843,9 +3867,17 @@ exports[`Story Snapshots: ModalImages should match snapshot 1`] = `
{
"color": "#2F343D",
},
{
"fontSize": 14,
},
[
{
"fontSize": 14,
},
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontWeight": "700",
"textAlign": "left",
},
],
]
}
>
Expand Down Expand Up @@ -5043,9 +5075,17 @@ exports[`Story Snapshots: ModalSectionAccessories should match snapshot 1`] = `
{
"color": "#2F343D",
},
{
"fontSize": 14,
},
[
{
"fontSize": 14,
},
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontWeight": "700",
"textAlign": "left",
},
],
]
}
>
Expand Down Expand Up @@ -5144,9 +5184,17 @@ exports[`Story Snapshots: ModalSectionAccessories should match snapshot 1`] = `
{
"color": "#2F343D",
},
{
"fontSize": 14,
},
[
{
"fontSize": 14,
},
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontWeight": "700",
"textAlign": "left",
},
],
]
}
>
Expand Down Expand Up @@ -5245,9 +5293,17 @@ exports[`Story Snapshots: ModalSectionAccessories should match snapshot 1`] = `
{
"color": "#2F343D",
},
{
"fontSize": 14,
},
[
{
"fontSize": 14,
},
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontWeight": "700",
"textAlign": "left",
},
],
]
}
>
Expand Down Expand Up @@ -5407,9 +5463,17 @@ exports[`Story Snapshots: ModalSectionAccessories should match snapshot 1`] = `
{
"color": "#2F343D",
},
{
"fontSize": 14,
},
[
{
"fontSize": 14,
},
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontWeight": "700",
"textAlign": "left",
},
],
]
}
>
Expand Down Expand Up @@ -5548,9 +5612,17 @@ exports[`Story Snapshots: ModalSectionAccessories should match snapshot 1`] = `
{
"color": "#2F343D",
},
{
"fontSize": 14,
},
[
{
"fontSize": 14,
},
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontWeight": "700",
"textAlign": "left",
},
],
]
}
>
Expand Down Expand Up @@ -5689,9 +5761,17 @@ exports[`Story Snapshots: ModalSectionAccessories should match snapshot 1`] = `
{
"color": "#2F343D",
},
{
"fontSize": 14,
},
[
{
"fontSize": 14,
},
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontWeight": "700",
"textAlign": "left",
},
],
]
}
>
Expand Down Expand Up @@ -5830,9 +5910,17 @@ exports[`Story Snapshots: ModalSectionAccessories should match snapshot 1`] = `
{
"color": "#2F343D",
},
{
"fontSize": 14,
},
[
{
"fontSize": 14,
},
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontWeight": "700",
"textAlign": "left",
},
],
]
}
>
Expand Down Expand Up @@ -5976,9 +6064,17 @@ exports[`Story Snapshots: ModalSectionSelects should match snapshot 1`] = `
{
"color": "#2F343D",
},
{
"fontSize": 14,
},
[
{
"fontSize": 14,
},
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontWeight": "700",
"textAlign": "left",
},
],
]
}
>
Expand Down Expand Up @@ -6203,9 +6299,17 @@ exports[`Story Snapshots: ModalSectionSelects should match snapshot 1`] = `
{
"color": "#2F343D",
},
{
"fontSize": 14,
},
[
{
"fontSize": 14,
},
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontWeight": "700",
"textAlign": "left",
},
],
]
}
>
Expand Down Expand Up @@ -6339,9 +6443,17 @@ exports[`Story Snapshots: ModalSectionSelects should match snapshot 1`] = `
{
"color": "#2F343D",
},
{
"fontSize": 14,
},
[
{
"fontSize": 14,
},
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontWeight": "700",
"textAlign": "left",
},
],
]
}
>
Expand Down Expand Up @@ -6488,9 +6600,17 @@ exports[`Story Snapshots: ModalSectionSelects should match snapshot 1`] = `
{
"color": "#2F343D",
},
{
"fontSize": 14,
},
[
{
"fontSize": 14,
},
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontWeight": "700",
"textAlign": "left",
},
],
]
}
>
Expand Down Expand Up @@ -6624,9 +6744,17 @@ exports[`Story Snapshots: ModalSectionSelects should match snapshot 1`] = `
{
"color": "#2F343D",
},
{
"fontSize": 14,
},
[
{
"fontSize": 14,
},
{
"backgroundColor": "transparent",
"fontFamily": "Inter",
"fontWeight": "700",
"textAlign": "left",
},
],
]
}
>
Expand Down
Loading
Loading