-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: ddp client #6800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rohit3523
wants to merge
246
commits into
develop
Choose a base branch
from
feat-ddp-client
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: ddp client #6800
Changes from all commits
Commits
Show all changes
246 commits
Select commit
Hold shift + click to select a range
ffb1e92
ddp client basic
Rohit3523 28cd8e7
Some more changes
Rohit3523 41760c6
Some rest api changes
Rohit3523 ed22661
some fix
Rohit3523 b8457df
more changes
Rohit3523 bb68c79
some more fix
Rohit3523 3fa1fd8
lock file fix
Rohit3523 5a4149c
some changes
Rohit3523 2cac93c
Merge branch 'develop' into feat-ddp-client
Rohit3523 984b0fa
lock file fix
Rohit3523 d0c792c
import fix
Rohit3523 f5a4e27
partially fixed
Rohit3523 e36d477
Merge branch 'develop' into feat-ddp-client
Rohit3523 73bcb05
lock
Rohit3523 348f2e0
more fix
Rohit3523 f7ca44b
added resolutions
Rohit3523 517a4cd
more changes
Rohit3523 80130ec
more type fix
Rohit3523 540a705
more ts fix
Rohit3523 f9c01e9
more
Rohit3523 5f34fc0
some more
Rohit3523 c222e1e
more
Rohit3523 a5f04d7
local map
Rohit3523 b1409da
Merge branch 'develop' into feat-ddp-client
Rohit3523 02a9f69
Merge branch 'develop' into feat-ddp-client
Rohit3523 13fdf96
using live packages
Rohit3523 c88edb7
more changes
Rohit3523 6d04d2c
some more type fix
Rohit3523 d5bfc2d
Merge branch 'develop' into feat-ddp-client
Rohit3523 9b3077b
more api changse
Rohit3523 17c846b
more fix
Rohit3523 9d30eb5
making code rabbit happy
Rohit3523 efed2b5
revert few changes
Rohit3523 ef3942e
more revert
Rohit3523 6246907
more revert
Rohit3523 54b0cd4
more revert
Rohit3523 3e134cd
revert
Rohit3523 122ecff
more revert
Rohit3523 8892016
more revert
Rohit3523 ba3ee5f
format code
Rohit3523 8229607
lint fix
Rohit3523 41d88d2
final revert
Rohit3523 fc0fd21
login fix
Rohit3523 396b6de
login fix
Rohit3523 818ffd7
more fix
Rohit3523 b1b4acc
fix stream-notify-user
Rohit3523 27138b9
directory fix
Rohit3523 b653f22
Merge branch 'develop' into feat-ddp-client
Rohit3523 60d2fe9
added normalizeResponseError
Rohit3523 b36b84c
fix type error
Rohit3523 c68fa3c
Merge branch 'develop' into feat-ddp-client
Rohit3523 49d5946
added api typings
Rohit3523 b0a73a6
Merge branch 'develop' into feat-ddp-client
Rohit3523 21eded2
test fix
Rohit3523 a5b7d77
Merge branch 'develop' into feat-ddp-client
Rohit3523 4fc942e
fix more api typings
Rohit3523 c4b1385
fix test
Rohit3523 fbf9f5e
fix methodCall
Rohit3523 e4ab324
fix
Rohit3523 6e9606e
fix test
Rohit3523 b639714
fix star message loading
Rohit3523 d2ce24c
disable keyboard focus on e2e builds
Rohit3523 e735369
logout change
Rohit3523 0db8b2d
chore: format code and fix lint issues
Rohit3523 4f31ec1
rerun ci
Rohit3523 34d7df3
revert
Rohit3523 2b1a212
making code rabbit happy
Rohit3523 fd91290
Merge branch 'develop' into feat-ddp-client
Rohit3523 e1a5e85
changes
Rohit3523 7d1a82b
reconnection logic on background
Rohit3523 c260ded
lint fix
Rohit3523 dfb7910
Merge branch 'develop' into feat-ddp-client
Rohit3523 720dfa6
changes
Rohit3523 1340541
chore: format code and fix lint issues
Rohit3523 22c3145
lint fix
Rohit3523 ae22543
Merge branch 'feat-ddp-client' of https://github.com/RocketChat/Rocke…
Rohit3523 a323f62
rerun ci
Rohit3523 b362cf7
revert
Rohit3523 fbdd901
rerun
Rohit3523 6854fd5
revert
Rohit3523 6f28c41
Merge branch 'develop' into feat-ddp-client
Rohit3523 3c91c2a
coderabbit changes
Rohit3523 b13b356
code improvements
Rohit3523 34ac089
more improve
Rohit3523 de84c6f
changes
Rohit3523 2c2df79
move sdk changes to a patch
Rohit3523 4acde09
remove away from get and delete in sdk
Rohit3523 ff913aa
more changes
Rohit3523 d8639f4
test update
Rohit3523 8ca2abb
snapshot update
Rohit3523 eb293b4
added some more unit test
Rohit3523 cb9d3c0
more changes
Rohit3523 4638d99
patch for typing
Rohit3523 53c8106
Merge branch 'develop' into feat-ddp-client
Rohit3523 47aacde
Merge branch 'develop' into feat-ddp-client
Rohit3523 f2c0ec9
test fixed
Rohit3523 887f8c5
get settings test
Rohit3523 685eab3
chore: format code and fix lint issues
Rohit3523 84bcdc2
retrigger ci
Rohit3523 672146c
revert
Rohit3523 f26c241
Merge branch 'feat-ddp-client' of https://github.com/RocketChat/Rocke…
Rohit3523 c64f908
improvements
Rohit3523 0397c8c
test update
Rohit3523 c064270
changes
Rohit3523 1a15187
revert connect change
Rohit3523 305984d
fix
Rohit3523 0283cbb
fix for 2fa
Rohit3523 c8a415c
revert dm delete
Rohit3523 fccba68
test fix
Rohit3523 040ed90
chore: format code and fix lint issues
Rohit3523 8d69734
fix test
Rohit3523 6f7ed09
Merge branch 'feat-ddp-client' of https://github.com/RocketChat/Rocke…
Rohit3523 243e71c
test update
Rohit3523 945bbb8
improve
Rohit3523 7b9ad20
more test and changes
Rohit3523 948a8bb
another test
Rohit3523 f5b53c3
fix suggestion by coderabbit
Rohit3523 2d8bd30
more tests
Rohit3523 09fcfe4
remove todo test
Rohit3523 52711b0
fix eslint...
Rohit3523 5145c08
more changes
Rohit3523 2ad1957
fix
Rohit3523 af7f9dd
Merge branch 'develop' into feat-ddp-client
Rohit3523 18777a4
test(deepLinking): update sdk mock from client.host to sdk.server
Rohit3523 2819208
deeplinking changes
Rohit3523 89f7205
Merge branch 'develop' into feat-ddp-client
Rohit3523 4cf875f
Added mock device-info for versions to fix header snapshot
Rohit3523 73a85de
story update
Rohit3523 978429f
remove tserror
Rohit3523 ef96dee
Move back basicauthkey to fetch
Rohit3523 cf07ca2
Rename custom header to default header, matching file naming
Rohit3523 1d7ce92
chore: format code and fix lint issues
Rohit3523 f983538
add typed endpoint for media-calls.stateSignals
Rohit3523 4ac9b8a
Merge branch 'feat-ddp-client' of https://github.com/RocketChat/Rocke…
Rohit3523 0813eef
e2e test revert
Rohit3523 dd57f5f
sdk changes
Rohit3523 1cd9614
added restApi mock in voip
Rohit3523 76c1ad0
chore: format code and fix lint issues
Rohit3523 8f40f66
revert the changes of useAutoComplete
Rohit3523 8f2df16
Merge branch 'feat-ddp-client' of https://github.com/RocketChat/Rocke…
Rohit3523 66c648e
centralize auth headers in sdk
Rohit3523 e80a5bb
lint fix
Rohit3523 96661cb
making ts happy
Rohit3523 b70c1c9
added unit test to make sure header change for deeplink login and ser…
Rohit3523 a734133
fix anti pattern
Rohit3523 058fc2b
Merge branch 'develop' into feat-ddp-client
Rohit3523 9c78c17
Merge branch 'develop' into feat-ddp-client
Rohit3523 f59404c
lock file fix
Rohit3523 4a885b1
Merge branch 'develop' into feat-ddp-client
Rohit3523 ec42521
changes
Rohit3523 3a6d6b4
Merge branch 'feat-ddp-client' of https://github.com/RocketChat/Rocke…
Rohit3523 e7d2642
More changes
Rohit3523 53fcdec
test lint fix
Rohit3523 c723a1b
more changes
Rohit3523 0cebd28
Merge branch 'develop' into feat-ddp-client
Rohit3523 6acc6a3
lockfile update
Rohit3523 60b552b
fix: restore room reconnect/typing-cleanup via connection status list…
Rohit3523 78f590a
fix: log subscribeRoom failures instead of swallowing them
Rohit3523 1639639
chore: add edge-to-edge support on Android (#7157)
Rohit3523 d6427cd
fix: catch inquiry subscription rejection instead of letting it go un…
Rohit3523 4427675
fix: stop double-nesting stream-user-presence subscribe params
Rohit3523 21fedd6
fix: check /v1/login response via status field, not success
Rohit3523 310d921
fix: stop 2FA retry headers from leaking into concurrent requests
Rohit3523 a012e16
fix: stop the previous inquiry subscription before resubscribing
Rohit3523 e2487a3
chore: remove vestigial user param from sendAttachments
Rohit3523 0711725
fix: don't destroy the local upload record when mediaConfirm fails
Rohit3523 e94dea8
fix: log when Sdk.logout() times out instead of completing silently
Rohit3523 5ef4e80
test: cover the patched Connection reconnect/zombie-socket logic
Rohit3523 0dfdcb5
fix: add missing url field to IInvite and stop discarding its type
Rohit3523 fc662b6
chore: remove stray fix me comment above getDepartmentInfo
Rohit3523 d9b02f0
fix: guard optional cursor field and remove stale @ts-ignores
Rohit3523 10266f8
test: exercise logout() itself, not just removeServer
Rohit3523 216555e
Merge branch 'fix/ddp-9-connection-patch-tests' into fix/ddp-client-m…
Rohit3523 cce1eb6
Merge branch 'fix/ddp-10-logout-test' into fix/ddp-client-migration-i…
Rohit3523 69f5ef4
Merge branch 'fix/ddp-11-inquiry-leak' into fix/ddp-client-migration-…
Rohit3523 062d6fd
Merge branch 'fix/ddp-13-cursor-bug' into fix/ddp-client-migration-is…
Rohit3523 e41ee3e
Merge branch 'fix/ddp-14-restapi-invite' into fix/ddp-client-migratio…
Rohit3523 7fb67cd
Merge branch 'fix/ddp-18-send-attachments' into fix/ddp-client-migrat…
Rohit3523 9198704
Merge branch 'fix/ddp-20-media-confirm' into fix/ddp-client-migration…
Rohit3523 0e6bbb1
fix: remove unused disconnect import left by an incomplete amend
Rohit3523 71c58fb
fix: bail out of connect() if a newer call already switched servers
Rohit3523 c88fe76
test: actually invoke the registered 2FA challenge handler
Rohit3523 e47a1af
docs: fix stale JSDoc and document non-obvious auth/2FA/logout behavior
Rohit3523 04ac6a5
fix: use the project's log() helper instead of console.log/error in c…
Rohit3523 80f9872
fix: guard stream-notify-all/logged and stream-roles against fieldles…
Rohit3523 01d9358
Merge branch 'fix/ddp-client-migration-issues' into feat-ddp-client
Rohit3523 32dc416
Merge branch 'develop' into feat-ddp-client
Rohit3523 921f920
Merge branch 'develop' into feat-ddp-client
Rohit3523 a768f3e
lint fix
Rohit3523 bf20df2
Merge branch 'develop' into feat-ddp-client
Rohit3523 72661f4
Changes
Rohit3523 eec64f6
remove custom id and token extend
Rohit3523 187b02e
Merge branch 'develop' into feat-ddp-client
Rohit3523 478f764
changes
Rohit3523 83226a4
test fix
Rohit3523 c45be78
Merge branch 'develop' into feat-ddp-client
Rohit3523 cd87f22
remove another unnecessary change
Rohit3523 f3adec5
test improve
Rohit3523 8cb18e7
some changes
Rohit3523 3104d5d
k one more patch this time
Rohit3523 0a03fd0
test fix
Rohit3523 ba9bb94
remove main pointing
Rohit3523 1a4527e
more changes
Rohit3523 3f8b9ac
prevent token from being send in header for cross origin url
Rohit3523 8dbff82
added server guard before sdk login
Rohit3523 5928660
check server before listners start
Rohit3523 e14854c
inquiry improvement
Rohit3523 a21b658
register all listners before connect
Rohit3523 0b7808b
more changes
Rohit3523 74f5ff4
handle other active user presence updates
Rohit3523 279e483
lint fix
Rohit3523 b6a6366
lint fix
Rohit3523 f463753
check for user login before switching server
Rohit3523 b9e427f
normalized response
Rohit3523 d77a0dd
user preference change for token
Rohit3523 f2b79bb
remove a comment
Rohit3523 a012343
new test
Rohit3523 d0819ed
using stop in room sub
Rohit3523 42cc9df
fix type
Rohit3523 ddc6923
remove unwanted comment
Rohit3523 5271af8
return false on error and no origin provided
Rohit3523 4e891c1
change...
Rohit3523 881da59
test update
Rohit3523 71e5945
Merge branch 'develop' into feat-ddp-client
Rohit3523 4fb0d80
Merge remote-tracking branch 'origin/develop' into feat-ddp-client
Rohit3523 ed2ea3c
fix
Rohit3523 5ae2868
chore: format code and fix lint issues
Rohit3523 ec73e95
test fix
Rohit3523 516e6d0
some improvements
Rohit3523 3505eb8
minor changes
Rohit3523 9e8f672
some improvements
Rohit3523 31af37e
test fix
Rohit3523 a4b35d9
api-client patch update
Rohit3523 79610c4
Merge branch 'develop' into feat-ddp-client
Rohit3523 50fe9c5
improve
Rohit3523 dcc7534
chore: format code and fix lint issues
Rohit3523 15fbc62
code rabnit suggestions
Rohit3523 52fc781
new changes to align with new patch
Rohit3523 75b56eb
Merge branch 'develop' into feat-ddp-client
Rohit3523 e2b3387
Merge branch 'develop' into feat-ddp-client
Rohit3523 4586623
rename handleLogin to handleConnection
Rohit3523 9de06cd
remame rawSubscriptionHandles to subscriptionHandles
Rohit3523 d4ff6b6
using handleConnection in test...
Rohit3523 313bc77
remove unwanted comments
Rohit3523 dab8e41
remove unwanted checkAndReopen
Rohit3523 98197fa
added await
Rohit3523 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| import mockDeviceInfo from 'react-native-device-info/jest/react-native-device-info-mock'; | ||
|
|
||
| mockDeviceInfo.getSystemVersion = jest.fn(() => '14.0'); | ||
| mockDeviceInfo.getVersion = jest.fn(() => '1.0.0'); | ||
| mockDeviceInfo.getBuildNumber = jest.fn(() => '1'); | ||
|
|
||
| export default mockDeviceInfo; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These mock values were added because, without them, the test snapshot displayed unknown values in the header's User-Agent.
Before:
"RC Mobile; ios unknown; vunknown (unknown)"After:
"RC Mobile; ios 14.0; v1.0.0 (1)"