Skip to content

chore: Upgrade @gorhom/bottom-sheet to 5.2.6 #6729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
diegolmello wants to merge 20 commits into from
Closed

chore: Upgrade @gorhom/bottom-sheet to 5.2.6 #6729

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
6f2a8f2
Switch to gorhom's bottomsheet and write stories
diegolmello Oct 14, 2025
216b730
Merge branch 'develop' into chore.gorhom-bottom-sheet
OtavioStasiak Jan 16, 2026
f7a1161
chore: format code and fix lint issues [skip ci]
OtavioStasiak Jan 16, 2026
ff0a11a
fix: type and lock
OtavioStasiak Jan 16, 2026
3b6c8db
fix: snapshot tests
OtavioStasiak Jan 16, 2026
3b0794a
Wrap few components to bottomsheetview
Rohit3523 Jan 18, 2026
c1429b1
Using bottom sheet 5.2.8
Rohit3523 Jan 18, 2026
b689833
Remove bottomsheetview from support version
Rohit3523 Jan 18, 2026
3f8a600
Lint fix
Rohit3523 Jan 18, 2026
b83d42a
chore: format code and fix lint issues [skip ci]
Rohit3523 Jan 18, 2026
9fd9a82
Some fix
Rohit3523 Jan 18, 2026
001f3b5
chore: format code and fix lint issues [skip ci]
Rohit3523 Jan 18, 2026
f387a85
snapshot update
Rohit3523 Jan 18, 2026
36e21ba
Index fix for few
Rohit3523 Jan 18, 2026
c1a0f41
pod lock change
Rohit3523 Jan 18, 2026
3faffe7
chore: format code and fix lint issues [skip ci]
Rohit3523 Jan 18, 2026
b85f747
Merge branch 'develop' into chore.gorhom-bottom-sheet
Rohit3523 Jan 22, 2026
b68af6e
Merge branch 'develop' into chore.gorhom-bottom-sheet
Rohit3523 Feb 5, 2026
cbc149a
index change
Rohit3523 Feb 5, 2026
67e56ea
revert index change
Rohit3523 Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
608 changes: 608 additions & 0 deletions app/containers/ActionSheet/ActionSheet.stories.tsx
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions app/containers/ActionSheet/ActionSheet.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import { generateSnapshots } from '../../../.rnstorybook/generateSnapshots';
import * as stories from './ActionSheet.stories';

generateSnapshots(stories);
9 changes: 7 additions & 2 deletions app/containers/ActionSheet/ActionSheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import { useBackHandler } from '@react-native-community/hooks';
import * as Haptics from 'expo-haptics';
import React, { forwardRef, isValidElement, useEffect, useImperativeHandle, useRef, useState, useCallback } from 'react';
import { Keyboard, LayoutChangeEvent, useWindowDimensions } from 'react-native';
import { Easing, useDerivedValue, useSharedValue } from 'react-native-reanimated';
import BottomSheet, { BottomSheetBackdrop, BottomSheetBackdropProps } from '@discord/bottom-sheet';
import { Easing, ReduceMotion, useDerivedValue, useSharedValue } from 'react-native-reanimated';
import BottomSheet, { BottomSheetBackdrop, BottomSheetBackdropProps } from '@gorhom/bottom-sheet';
import { useSafeAreaInsets } from 'react-native-safe-area-context';

import { useTheme } from '../../theme';
Expand Down Expand Up @@ -167,6 +167,11 @@ const ActionSheet = React.memo(
onChange={index => index === -1 && onClose()}
// We need this to allow horizontal swipe gesture inside the bottom sheet like in reaction picker
enableContentPanningGesture={data?.enableContentPanningGesture ?? true}
accessible={undefined}
accessibilityRole={undefined}
accessibilityLabel={undefined}
accessibilityHint={undefined}
overrideReduceMotion={ReduceMotion.Never}
Comment on lines +170 to +174

@coderabbitai coderabbitai Bot Jan 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

@gorhom/bottom-sheet ReduceMotion.Never accessibility reduce motion

💡 Result:

Yes — @gorhom/bottom-sheet supports overriding the system Reduce Motion setting via the overrideReduceMotion prop. Use ReduceMotion.Never to force animations even when the device's "Reduce Motion" accessibility option is enabled. Example:

  • import and usage:
    • <BottomSheet overrideReduceMotion={ReduceMotion.Never} ... />. [1]

Reference: props doc for overrideReduceMotion (ReduceMotion.System | Always | Never). [1] Reanimated docs on ReduceMotion enums and behavior. [2]

Sources

  • [1] gorhom bottom-sheet props — overrideReduceMotion.
  • [2] React Native Reanimated accessibility guide (ReduceMotion.System / Always / Never).

🏁 Script executed:

find . -name "ActionSheet.tsx" -type f | head -5

Repository: RocketChat/Rocket.Chat.ReactNative

Length of output: 212

🏁 Script executed:

git ls-files | grep -i "ActionSheet.tsx"

Repository: RocketChat/Rocket.Chat.ReactNative

Length of output: 212

Accessibility concern: overrideReduceMotion={ReduceMotion.Never} ignores user preferences.

Setting ReduceMotion.Never forces animations even when users have enabled "Reduce Motion" in their device accessibility settings. This can cause discomfort for users with vestibular disorders or motion sensitivity.

Use ReduceMotion.System instead to respect the user's accessibility preferences:

Suggested fix 
-						overrideReduceMotion={ReduceMotion.Never}
+						overrideReduceMotion={ReduceMotion.System}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
accessible={undefined}
accessibilityRole={undefined}
accessibilityLabel={undefined}
accessibilityHint={undefined}
overrideReduceMotion={ReduceMotion.Never}
accessible={undefined}
accessibilityRole={undefined}
accessibilityLabel={undefined}
accessibilityHint={undefined}
overrideReduceMotion={ReduceMotion.System}
🤖 Prompt for AI Agents 
In `@app/containers/ActionSheet/ActionSheet.tsx` around lines 170 - 174, The
ActionSheet is forcing animations by setting
overrideReduceMotion={ReduceMotion.Never}, which ignores user "Reduce Motion"
preferences; locate the overrideReduceMotion prop usage in ActionSheet
(ActionSheet.tsx) and change it to ReduceMotion.System so the component respects
system accessibility settings (ensure the ReduceMotion enum/import is available
and adjust any tests or callers if they rely on the forced behavior).

{...androidTablet}>
<BottomSheetContent
options={data?.options}
Expand Down
Loading
Loading