-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(a11y): toasts to native dialogs #6514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
c6d4d6f
feat: new i18n translation
OtavioStasiak bef7645
feat: add listPicker
OtavioStasiak f3ee28d
feat: layout and code improvements
OtavioStasiak a6d4af8
fix: copy and a11y label read
OtavioStasiak 6eab1bf
feat: added hint to Toasts option
OtavioStasiak a05b735
feat: e2e tests
OtavioStasiak ecdb893
fix: jest mock and imports
OtavioStasiak 242ee92
fix: jest
OtavioStasiak a3c4cfd
fix: code improvements
OtavioStasiak bfaa8ae
fix: zh-CN translation
OtavioStasiak cacfc44
fix: te-IN translation
OtavioStasiak 4bbc583
fix: no translation
OtavioStasiak 6aaa498
fix: nl translation
OtavioStasiak 2c8c14d
fix: hu translation
OtavioStasiak cc1b109
fix: fi translation
OtavioStasiak 76202d5
fix: es translation
OtavioStasiak 3309ea0
fix: tr translation
OtavioStasiak 796fb77
chore: code improvements
OtavioStasiak b56609b
chore: code improvements
OtavioStasiak e819734
fix: remove extra pause if there is no subtitle
OtavioStasiak cd5dbc0
fix: i18n ListPicker
OtavioStasiak 5bb90bc
fix: i18n translation
OtavioStasiak 352be70
Merge branch 'develop' into feat-a11y-toasts-to-native-dialogs
OtavioStasiak eb9d3cf
fix: it translation
OtavioStasiak 140b05b
Update app/i18n/locales/sv.json
OtavioStasiak f81906f
fix: translation
OtavioStasiak 71c7195
Merge branch 'develop' into feat-a11y-toasts-to-native-dialogs
OtavioStasiak a368220
fix: remove unused useMemo
OtavioStasiak 9679d6b
Merge branch 'develop' into feat-a11y-toasts-to-native-dialogs
OtavioStasiak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
38 changes: 38 additions & 0 deletions
38
.maestro/tests/accessibilityAndAppearance/ToastsAndDialogs.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| appId: chat.rocket.reactnative | ||
| name: Toasts and Dialogs | ||
| onFlowStart: | ||
| - runFlow: '../../helpers/setup.yaml' | ||
| onFlowEnd: | ||
| - evalScript: ${output.utils.deleteCreatedUsers()} | ||
|
|
||
| --- | ||
| - runFlow: ../../helpers/launch-app.yaml | ||
| - runFlow: ../../helpers/login.yaml | ||
|
|
||
| # Show alerts as Toasts | ||
| - tapOn: 'Menu' | ||
| - tapOn: 'Accessibility & appearance' | ||
| - tapOn: 'Show alerts as. Toasts' | ||
| - assertVisible: 'Toasts. Dismissed automatically. Checked' | ||
| - assertVisible: 'Dialogs. Require manual dismissal. Unchecked' | ||
| - tapOn: 'Bottom Sheet backdrop' | ||
| - tapOn: 'Menu' | ||
| - tapOn: 'Edit status' | ||
| - tapOn: | ||
| id: 'status-view-offline' | ||
| - tapOn: 'Save' | ||
| - assertVisible: 'Status saved successfully!' | ||
|
|
||
| # Show alerts as Dialogs | ||
| - tapOn: 'Accessibility & appearance' | ||
| - tapOn: 'Show alerts as. Toasts' | ||
| - assertVisible: 'Toasts. Dismissed automatically. Checked' | ||
| - tapOn: 'Dialogs. Require manual dismissal. Unchecked' | ||
| - tapOn: 'Menu' | ||
| - tapOn: 'Edit status' | ||
| - tapOn: | ||
| id: 'status-view-online' | ||
| - tapOn: 'Save' | ||
| - assertVisible: 'Status saved successfully!' | ||
| - assertVisible: 'OK' | ||
| - tapOn: 'OK' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Confirm ActionSheet backdrop selector exists
“Bottom Sheet backdrop” must match an accessible label/testID; otherwise this step will flake.
Run to verify and adjust selector if needed:
🏁 Script executed:
Length of output: 20680
Backdrop selector missing — tests will flake
'Bottom Sheet backdrop' is not present in the repo. Either:
🤖 Prompt for AI Agents