Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import StorybookConfig explicitly as type #6122

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cardoso
Copy link

@cardoso cardoso commented Feb 1, 2025

Proposed changes

This type import should be explicit to avoid a runtime error in certain dev environment setups where type-stripping is less robust (eg: node >=23.6). The change shouldn't affect setups where this currently works, since the syntax itself was introduced in ts 3.8. It's simply more widely supported.

Refs:

Issue(s)

How to test or reproduce

With node >=23.6
yarn ios

Screenshots

Screenshot 2025-01-31 at 22 27 05

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant