Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(a11y): Read receipts icons and accessibility label #6118

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified android/app/src/main/assets/fonts/custom.ttf
Binary file not shown.
1 change: 1 addition & 0 deletions app/containers/CustomIcon/mappedIcons.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export const mappedIcons = {
'chat-close': 59701,
'chat-forward': 59702,
'check': 59703,
'check-double': 59855,
'checkbox-checked': 59654,
'checkbox-unchecked': 59653,
'chevron-down': 59704,
Expand Down
2 changes: 1 addition & 1 deletion app/containers/CustomIcon/selection.json

Large diffs are not rendered by default.

12 changes: 4 additions & 8 deletions app/containers/message/Components/RightIcons/ReadReceipt.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,11 @@ import { useTheme } from '../../../../theme';

const ReadReceipt = React.memo(({ isReadReceiptEnabled, unread }: { isReadReceiptEnabled?: boolean; unread?: boolean }) => {
const { colors } = useTheme();
const iconName = !unread && unread !== null ? 'check-double' : 'check';
const iconColor = !unread && unread !== null ? colors.fontInfo : colors.fontAnnotation;

if (isReadReceiptEnabled) {
return (
<CustomIcon
name='check'
color={!unread && unread !== null ? colors.badgeBackgroundLevel2 : colors.fontHint}
size={16}
style={styles.rightIcons}
/>
);
return <CustomIcon name={iconName} color={iconColor} size={16} style={styles.rightIcons} />;
}
return null;
});
Expand Down
4 changes: 3 additions & 1 deletion app/containers/message/Message.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,9 @@ const MessageTouchable = React.memo((props: IMessageTouchable & IMessage) => {
}
const hour = props.ts ? new Date(props.ts).toLocaleTimeString() : '';
const user = props.useRealName ? props.author?.name : props.author?.username || '';
return `${user} ${hour} ${label}`;
const readOrUnreadLabel = !props.unread && props.unread !== null ? i18n.t('Read') : i18n.t('Unread');
const readReceipt = props.isReadReceiptEnabled ? readOrUnreadLabel : '';
return `${user} ${hour} ${label} ${readReceipt}`;
}, []);

if (props.hasError) {
Expand Down
1 change: 1 addition & 0 deletions app/i18n/locales/ar.json
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,7 @@
"Quote": "اقتباس",
"Reactions_are_disabled": "التفاعل معطل",
"Reactions_are_enabled": "التفاعل مفعل",
"Read": "اقرأ",
"Read_External_Permission": "صلاحية قراءة الوسائط",
"Read_External_Permission_Message": "يحتاج Rocket.chat للوصول إلى الصور والملفات الموجودة على الجهاز",
"Read_Only": "قراءة فقط",
Expand Down
3 changes: 2 additions & 1 deletion app/i18n/locales/bn-IN.json
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,7 @@
"Quote": "উদ্ধৃতি",
"Reactions_are_disabled": "রিয়েকশনগুলি অক্ষম করা হয়েছে",
"Reactions_are_enabled": "রিয়েকশনগুলি সক্ষম করা হয়েছে",
"Read": "পড়ুন।",
"Read_External_Permission": "মিডিয়া অনুমতি পড়া",
"Read_External_Permission_Message": "Rocket.Chat আপনার ডিভাইসে ফটো, মিডিয়া এবং ফাইল অ্যাক্সেস করতে পারে",
"Read_Only": "শুধুমাত্র পড়া",
Expand Down Expand Up @@ -695,7 +696,7 @@
"Unmute": "আনমিউট",
"unmuted": "আনমিউটেড",
"Unpin": "আনপিন",
"Unread": "অপঠিত",
"Unread": "অআপঠিত",
"unread_messages": "অপঠিত",
"Unread_on_top": "শীর্ষে অপঠিত",
"Unstar": "আনস্টার",
Expand Down
3 changes: 2 additions & 1 deletion app/i18n/locales/cs.json
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,7 @@
"Quote": "Citát",
"Reactions_are_disabled": "Reakce jsou zakázány",
"Reactions_are_enabled": "Reakce jsou povoleny",
"Read": "Číst",
"Read_External_Permission": "Povolení ke čtení médií",
"Read_External_Permission_Message": "Rocket.Chat potřebuje přístup k fotografiím, médiím a souborům ve vašem zařízení",
"Read_Only": "Pouze ke čtení",
Expand Down Expand Up @@ -764,7 +765,7 @@
"Unmute_someone_in_room": "Zrušte zvuk někoho v místnosti",
"unmuted": "neztlumeno",
"Unpin": "Uvolnit",
"Unread": "Nepřečtený",
"Unread": "Nepřečteno",
"unread_messages": "nepřečtený",
"Unread_on_top": "Nepřečteno nahoře",
"Unstar": "Odebrat hvězdičku",
Expand Down
3 changes: 2 additions & 1 deletion app/i18n/locales/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,7 @@
"Quote": "Zitat",
"Reactions_are_disabled": "Reaktionen sind deaktiviert",
"Reactions_are_enabled": "Reaktionen sind aktiviert",
"Read": "Lesen",
"Read_External_Permission": "Lese-Zugriff auf Medien",
"Read_External_Permission_Message": "Rocket.Chat benötigt Zugriff auf Ihre Fotos, Medien und Dateien auf Ihrem Gerät",
"Read_Only": "Schreibgeschützt",
Expand Down Expand Up @@ -689,7 +690,7 @@
"Unmute_someone_in_room": "Jemandem das Chatten in einem Raum wieder erlauben",
"unmuted": "Stummschaltung aufgehoben",
"Unpin": "Nachricht nicht mehr anheften",
"Unread": "ungelesene",
"Unread": "Ungelesen",
"unread_messages": "ungelesene",
"Unread_on_top": "Ungelesene oben",
"Unstar": "von Favoriten entfernen",
Expand Down
1 change: 1 addition & 0 deletions app/i18n/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,7 @@
"Quote": "Quote",
"Reactions_are_disabled": "Reactions are disabled",
"Reactions_are_enabled": "Reactions are enabled",
"Read": "Read",
"Read_External_Permission": "Read media permission",
"Read_External_Permission_Message": "Rocket.Chat needs to access photos, media, and files on your device",
"Read_Only": "Read only",
Expand Down
3 changes: 2 additions & 1 deletion app/i18n/locales/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@
"Quote": "Citar",
"Reactions_are_disabled": "Las reacciones están desactivadas",
"Reactions_are_enabled": "Las reacciones están activadas",
"Read": "Leer",
"Read_Only": "Sólo lectura ",
"Read_only_hint": "Solo los propietarios de canales pueden enviar nuevos mensajes",
"Read_Receipt": "Comprobante de lectura",
Expand Down Expand Up @@ -299,7 +300,7 @@
"Unmute_someone_in_room": "Reactivar audio de un usuario de la sala",
"unmuted": "Desmuteado",
"Unpin": "Quitar estado fijado",
"Unread": "Marcar como no leído",
"Unread": "No leído",
"unread_messages": "marcar como no leído",
"Unread_on_top": "Mensajes no leídos en la parte superior",
"Unstar": "Quitar destacado",
Expand Down
3 changes: 2 additions & 1 deletion app/i18n/locales/fi.json
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,7 @@
"Quote": "Lainaus",
"Reactions_are_disabled": "Reaktiot eivät ole käytössä",
"Reactions_are_enabled": "Reaktiot ovat käytössä",
"Read": "Lue",
"Read_External_Permission": "Median lukuoikeus",
"Read_External_Permission_Message": "Rocket.Chat tarvitsee pääsyn laitteesi valokuviin, mediaan ja tiedostoihin",
"Read_Only": "Vain luku",
Expand Down Expand Up @@ -664,7 +665,7 @@
"Unmute_someone_in_room": "Kumoa jonkun mykistys huoneessa",
"unmuted": "poisti mykistyksen",
"Unpin": "Poista kiinnitys",
"Unread": "Lukemattomat",
"Unread": "Lukematon",
"unread_messages": "lukematonta",
"Unread_on_top": "Lukemattomat ylinnä",
"Unstar": "Poista tähti",
Expand Down
1 change: 1 addition & 0 deletions app/i18n/locales/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,7 @@
"Quote": "Citation",
"Reactions_are_disabled": "Les réactions sont désactivées",
"Reactions_are_enabled": "Les réactions sont activées",
"Read": "Lire",
"Read_External_Permission": "Permission de lecture des fichiers",
"Read_External_Permission_Message": "Rocket.Chat doit accéder aux photos, aux médias et aux fichiers sur votre appareil",
"Read_Only": "Lecture seule",
Expand Down
1 change: 1 addition & 0 deletions app/i18n/locales/hi-IN.json
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,7 @@
"Quote": "उद्धृति",
"Reactions_are_disabled": "प्रतिक्रियाएँ निष्क्रिय हैं",
"Reactions_are_enabled": "प्रतिक्रियाएँ सक्षम हैं",
"Read": "पढ़ें",
"Read_External_Permission": "मीडिया अनुमति पठन",
"Read_External_Permission_Message": "रॉकेट.चैट को आपके डिवाइस पर फ़ोटो, मीडिया और फ़ाइल तक पहुंच की आवश्यकता है",
"Read_Only": "केवल पठन",
Expand Down
1 change: 1 addition & 0 deletions app/i18n/locales/hu.json
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,7 @@
"Quote": "Idézet",
"Reactions_are_disabled": "A reakciók le vannak tiltva",
"Reactions_are_enabled": "A reakciók engedélyezve vannak",
"Read": "Olvasd/Olvasni",
"Read_External_Permission": "Médiaengedély olvasása",
"Read_External_Permission_Message": "A Rocket.Chat-nek hozzá kell férnie a készülékén lévő fényképekhez, médiához és fájlokhoz",
"Read_Only": "Csak olvasható",
Expand Down
1 change: 1 addition & 0 deletions app/i18n/locales/it.json
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@
"Quote": "Cita",
"Reactions_are_disabled": "Le reazioni sono disabilitate",
"Reactions_are_enabled": "Le reazioni sono abilitate",
"Read": "Leggere",
"Read_External_Permission": "Permesso di Lettura della Memoria",
"Read_External_Permission_Message": "Rocket.Chat deve accedere alle foto, media, e documenti sul tuo dispositivo",
"Read_Only": "Sola lettura",
Expand Down
1 change: 1 addition & 0 deletions app/i18n/locales/ja.json
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@
"Quote": "引用",
"Reactions_are_disabled": "リアクションは無効化されています",
"Reactions_are_enabled": "リアクションは有効化されています",
"Read": "読書",
"Read_Only": "読み取り専用",
"Read_only_hint": "チャネル所有者のみが新しいメッセージを送信できます",
"Read_Receipt": "レシートを見る",
Expand Down
1 change: 1 addition & 0 deletions app/i18n/locales/nl.json
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,7 @@
"Quote": "Citaat",
"Reactions_are_disabled": "Reacties zijn uitgeschakeld",
"Reactions_are_enabled": "Reacties zijn ingeschakeld",
"Read": "Lezen",
"Read_External_Permission": "Lees toestemming voor media",
"Read_External_Permission_Message": "Rocket.Chat heeft toegang nodig tot foto's, media en bestanden op je apparaat",
"Read_Only": "Alleen lezen",
Expand Down
3 changes: 2 additions & 1 deletion app/i18n/locales/pt-BR.json
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,7 @@
"Quote": "Citar",
"Reactions_are_disabled": "Reagir está desabilitado",
"Reactions_are_enabled": "Reagir está habilitado",
"Read": "Ler",
"Read_External_Permission": "Permissão de acesso à arquivos",
"Read_External_Permission_Message": "Rocket.Chat precisa acessar fotos, mídia e arquivos no seu dispositivo",
"Read_Only": "Somente leitura",
Expand Down Expand Up @@ -772,7 +773,7 @@
"Unmute_someone_in_room": "Ativar o som de alguém na sala",
"unmuted": "permitiu que o usuário fale",
"Unpin": "Desafixar Mensagem",
"Unread": "Não lidas",
"Unread": "Não lido",
"unread_messages": "não lidas",
"Unread_on_top": "Não lidas no topo",
"Unselected": "Não selecionado",
Expand Down
3 changes: 2 additions & 1 deletion app/i18n/locales/pt-PT.json
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@
"Quote": "Citar",
"Reactions_are_disabled": "Reacções desactivadas",
"Reactions_are_enabled": "Reacções activadas",
"Read": "Ler",
"Read_External_Permission": "Permissão de leitura da média",
"Read_External_Permission_Message": "Rocket.Chat precisa acessar fotos, média e arquivos em seu dispositivo",
"Read_Only": "Só de Leitura",
Expand Down Expand Up @@ -375,7 +376,7 @@
"Unmute_someone_in_room": "Remover silenciar de alguém na sala",
"unmuted": "silêncio removido",
"Unpin": "Desafixar",
"Unread": "Não lidas",
"Unread": "Não lido",
"unread_messages": "não lidas",
"Unread_on_top": "Não lidas no topo",
"Unstar": "Retirar estrela",
Expand Down
3 changes: 2 additions & 1 deletion app/i18n/locales/ru.json
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,7 @@
"Quote": "Цитата",
"Reactions_are_disabled": "Реакции отключены",
"Reactions_are_enabled": "Реакции активированы",
"Read": "Читать",
"Read_External_Permission": "Разрешение на Чтение Медиа",
"Read_External_Permission_Message": "Rocket.Chat необходим доступ к фотографиям, медиа и другим файлам на вашем устройстве",
"Read_Only": "Только для чтения",
Expand Down Expand Up @@ -641,7 +642,7 @@
"Unmute_someone_in_room": "Сделать незаглушенным кого-нибудь в комнате",
"unmuted": "Заглушивание отменено",
"Unpin": "Открепить",
"Unread": "Непрочитанные",
"Unread": "Непрочитанное",
"unread_messages": "непрочитанные",
"Unread_on_top": "Непрочитанные сверху",
"Unstar": "Снять отметку",
Expand Down
1 change: 1 addition & 0 deletions app/i18n/locales/sl-SI.json
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@
"Quote": "Citat",
"Reactions_are_disabled": "Reakcije so onemogočene",
"Reactions_are_enabled": "Reakcije so omogočene",
"Read": "Preberi",
"Read_External_Permission": "Dovoljenje za branje medija",
"Read_External_Permission_Message": "Rocket.Chat potrebuje dostop do fotografij, medijev in datotek v vaši napravi",
"Read_Only": "Le branje",
Expand Down
1 change: 1 addition & 0 deletions app/i18n/locales/sv.json
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,7 @@
"Quote": "Citat",
"Reactions_are_disabled": "Reaktioner är inaktiverade",
"Reactions_are_enabled": "Reaktioner är aktiverade",
"Read": "Läs",
"Read_External_Permission": "Behörighet att läsa media",
"Read_External_Permission_Message": "Rocket.Chat behöver åtkomst till foton, media och filer på enheten",
"Read_Only": "Skrivskyddat",
Expand Down
3 changes: 2 additions & 1 deletion app/i18n/locales/ta-IN.json
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,7 @@
"Quote": "மேற்கோள்",
"Reactions_are_disabled": "பிரதிகிதங்கள் முடக்கப்பட்டுவிட்டன",
"Reactions_are_enabled": "பிரதிகிதங்கள் செயற்படுத்தப்பட்டுள்ளன",
"Read": "படி",
"Read_External_Permission": "மீடியா அனுமதி",
"Read_External_Permission_Message": "ராக்கெட்.சேட் உங்கள் கருவியில் புகைப்படங்கள், மீடியா மற்றும் கோப்புகளுக்கு அணுகல் பெற விரும்புகின்றது",
"Read_Only": "மட்டுமே படிக்க முடியும்",
Expand Down Expand Up @@ -695,7 +696,7 @@
"Unmute": "மூடாது",
"unmuted": "மூடப்படவில்லை",
"Unpin": "அகற்று",
"Unread": "படிக்கப்படாத",
"Unread": "படிக்காதது",
"unread_messages": "படிக்கப்படாத",
"Unread_on_top": "மேலும் படிக்கப்படாத",
"Unstar": "நட்சத்திரம் அகற்று",
Expand Down
3 changes: 2 additions & 1 deletion app/i18n/locales/te-IN.json
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,7 @@
"Quote": "ఉదాహరణ",
"Reactions_are_disabled": "ప్రతిక్రియలు నిషేధించబడినవి",
"Reactions_are_enabled": "ప్రతిక్రియలు అనుమతించబడినవి",
"Read": "पढ़ें",
"Read_External_Permission": "మీడియా అనుమతి",
"Read_External_Permission_Message": "రాకెట్.చాట్ మీ పరికరాల్లో ఫోటోలను, మీడియాను మరియు ఫైళ్లను ప్రవేశించాలి",
"Read_Only": "కేవలం చదవడానికి",
Expand Down Expand Up @@ -694,7 +695,7 @@
"Unmute": "ఆధ్వర్యపరచించండి",
"unmuted": "ఆధ్వర్యపరచించబడింది",
"Unpin": "పిన్ చేయకోండి",
"Unread": "చదవని",
"Unread": "पढ़ा नहीं गया",
"unread_messages": "చదవని",
"Unread_on_top": "చదవని పైన",
"Unstar": "స్టార్ తీసుకో",
Expand Down
1 change: 1 addition & 0 deletions app/i18n/locales/tr.json
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,7 @@
"Quote": "Alıntı",
"Reactions_are_disabled": "Tepkiler devre dışı bırakıldı",
"Reactions_are_enabled": "Tepkiler etkinleştirildi",
"Read": "Okumak",
"Read_External_Permission": "Medya Okuma İzni ",
"Read_External_Permission_Message": "Rocket.Chat'in cihazınızdaki fotoğraflara, medyaya ve dosyalara erişmesi gerekiyor",
"Read_Only": "Yazma Kısıtlı",
Expand Down
1 change: 1 addition & 0 deletions app/i18n/locales/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@
"Quote": "引用",
"Reactions_are_disabled": "表情貼被禁用",
"Reactions_are_enabled": "表情貼被启用",
"Read": "阅读",
"Read_External_Permission": "读取媒体权限",
"Read_External_Permission_Message": "Rocket.Chat 需要存取您装置上的相片、多媒体及文件",
"Read_Only": "只读",
Expand Down
1 change: 1 addition & 0 deletions app/i18n/locales/zh-TW.json
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,7 @@
"Quote": "引用",
"Reactions_are_disabled": "表情貼被禁用",
"Reactions_are_enabled": "表情貼被啟用",
"Read": "閱讀",
"Read_External_Permission": "讀取媒體權限",
"Read_External_Permission_Message": "Rocket.Chat 需要存取您裝置上的相片、多媒體及檔案",
"Read_Only": "唯讀",
Expand Down
Binary file modified ios/custom.ttf
Binary file not shown.