Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(a11y): Titles from menus marked as headings #6105

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore(a11y): Titles from menus marked as headings #6105

wants to merge 1 commit into from

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Jan 24, 2025 •
edited
Loading

Proposed changes

Add accessibility Role 'header' on Titles from menus.

Issue(s)

https://rocketchat.atlassian.net/browse/MA-114

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak changed the title chore: added accessibilityRole on listHeader chore(a11y): Titles from menus marked as headings Jan 24, 2025
@OtavioStasiak OtavioStasiak marked this pull request as ready for review January 24, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@OtavioStasiak