Skip to content

Conversation

@OtavioStasiak
Copy link
Contributor

Proposed changes

In our production version, when you try to log in to a two-factor account and click 'Cancel,' the Login button remains loading and disabled because the isFetching state is not updated. This PR fixes that issue.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-737

How to test or reproduce

  • Open the app;
  • Try to log in on account with two factor enabled.
  • click on cancel;

Screenshots

| Before | After |

| before | after |

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak marked this pull request as ready for review December 13, 2024 19:57
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the appropriate fix imo.
It's a regression that started on #6008

@diegolmello diegolmello changed the title fix: inifite loading on two factor login regression: infinite loading on login button after TOTP cancel Jan 8, 2025
@OtavioStasiak
Copy link
Contributor Author

OtavioStasiak commented Jan 8, 2025

This is the appropriate fix imo. It's a regression that started on #6008

Got it, I've just tested the new solution and it works!

@diegolmello diegolmello force-pushed the fix-two-factor-loading-on-cancel branch from 0f27f49 to ebbf3ae Compare February 27, 2025 13:47
@diegolmello diegolmello merged commit 2e9eec1 into develop Feb 27, 2025
3 of 5 checks passed
@diegolmello diegolmello deleted the fix-two-factor-loading-on-cancel branch February 27, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants