Skip to content

Conversation

@Rohit3523
Copy link
Contributor

Proposed changes

This pull request introduces absolute paths for module imports in the React Native app. The changes enhance code readability and maintainability by replacing relative import paths (e.g., ../../../) with easily understandable absolute paths.

Issue(s)

N/A

How to test or reproduce

N/A

Screenshots

N/A

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

@Rohit3523 Rohit3523 marked this pull request as draft November 26, 2024 18:06
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint is failing

@Rohit3523
Copy link
Contributor Author

This one is not completed as i have to change more files, should i do in batches?

@diegolmello diegolmello changed the title Refactor: Use Absolute Paths for Module Imports chore: Use Absolute Paths for Module Imports Mar 6, 2025
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great start!

This one is not completed as i have to change more files, should i do in batches?

You shouldn't do it manually. yarn prettier-lint should apply this to all files.

You'll have to change lint and import order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants