Skip to content

chore(a11y): E2EEnterYourPasswordView #6010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OtavioStasiak merged 11 commits into from
Jan 13, 2025
Merged

chore(a11y): E2EEnterYourPasswordView #6010

OtavioStasiak merged 11 commits into from
Jan 13, 2025

Conversation

@OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Nov 18, 2024 •
edited
Loading

Proposed changes

Added accessibility features to the E2EEnterYourPasswordView.

Issue(s)

https://rocketchat.atlassian.net/browse/MA-186

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak changed the title chore (a11y): E2EEnterYourPasswordView chore(a11y): E2EEnterYourPasswordView Nov 18, 2024
@OtavioStasiak OtavioStasiak force-pushed the chore-a11y-e2e-enter-password-view branch from be1d503 to 678d3b2 Compare November 22, 2024 03:16
@OtavioStasiak OtavioStasiak marked this pull request as ready for review November 22, 2024 03:35
diegolmello
diegolmello requested changes Dec 9, 2024
View reviewed changes
diegolmello
diegolmello reviewed Dec 9, 2024
View reviewed changes
@OtavioStasiak OtavioStasiak merged commit 2a82fe4 into develop Jan 13, 2025
4 of 9 checks passed
@OtavioStasiak OtavioStasiak deleted the chore-a11y-e2e-enter-password-view branch January 13, 2025 14:59
@OtavioStasiak OtavioStasiak mentioned this pull request Apr 10, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegolmello diegolmello diegolmello approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OtavioStasiak @diegolmello