Skip to content

regression(Android): Poor performance in messages list - #5267

Merged
dnlsilva merged 2 commits into
developfrom
fix-android-room-view-performance
Oct 13, 2023
Merged

regression(Android): Poor performance in messages list#5267
dnlsilva merged 2 commits into
developfrom
fix-android-room-view-performance

Conversation

@dnlsilva

@dnlsilva dnlsilva commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

In this PR #5251 we removed RefreshControl, however it caused a loss of performance when using the app.
This PR removes RefreshControl without impacting performance.

Issue(s)

How to test or reproduce

Navigate to a room and check whether the performance when navigating between messages is acceptable.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: NATIVE-410

@dnlsilva dnlsilva changed the title regression(Android): Remove RefreshControl from messages list regression(Android): Poor performance in messages list Oct 11, 2023
@dnlsilva dnlsilva changed the title regression(Android): Poor performance in messages list regression: Poor performance in messages list - Android Oct 11, 2023
@diegolmello diegolmello changed the title regression: Poor performance in messages list - Android regression(Android): Poor performance in messages list Oct 11, 2023
@dnlsilva
dnlsilva merged commit 231057a into develop Oct 13, 2023
@dnlsilva
dnlsilva deleted the fix-android-room-view-performance branch October 13, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants