Skip to content

Conversation

@dnlsilva
Copy link
Contributor

@dnlsilva dnlsilva commented Jul 31, 2023

Proposed changes

This PR added a regression: #3778
It is not possible to see the user's roles, but since a long time ago, how the roles are taken by the front has changed, so this PR corrects this error and changes the logic to be similar to the front.

Note: The user api does not return the roles anymore to normal users, only users with permission.

RocketChat/Rocket.Chat#22345

Issue(s)

How to test or reproduce

  • Enter the information screen of a user who has a role.

Screenshots

Before:
Screenshot 2023-07-31 at 18 46 07

After:
Screenshot 2023-07-31 at 18 42 15

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: TC-847

@dnlsilva dnlsilva marked this pull request as ready for review July 31, 2023 21:46
Copy link
Contributor

@reinaldonetof reinaldonetof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was testing here and during some tests, I noticed that the role wasn't showing properly

Example:
Screen Shot 2023-07-31 at 21 10 10

I was expecting this:
Screen Shot 2023-07-31 at 21 10 47

This was using the candidate.

@diegolmello diegolmello changed the title regresion: show roles on user info view regression: show roles on user info view Aug 7, 2023
@reinaldonetof reinaldonetof merged commit b23df26 into develop Aug 11, 2023
@reinaldonetof reinaldonetof deleted the fix-roles branch August 11, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants