regression: fix blank 'Name' field in Profile View when modifying other fields - #5101
Merged
Merged
Conversation
…lank 'Name' field inside the Profile View
Contributor
|
Does the fix remove the name? It was working before, wasn't it? |
Contributor
Author
The screenshots were swapped. Now they are in correct order |
dnlsilva
approved these changes
Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pull request addresses an issue where modifying any field other than the 'Name' field in the Profile View resulted in the 'Name' field becoming blank. The fix ensures that the 'Name' field retains its value when making changes to other profile fields.
Regression from #4513
Issue(s)
How to test or reproduce
Screenshots
Before
Screen.Recording.2023-06-06.at.20.32.26.mov
After
Screen.Recording.2023-06-06.at.20.33.17.mov
Types of changes
Checklist
Further comments
TC-717