Skip to content

regression: fix blank 'Name' field in Profile View when modifying other fields - #5101

Merged
reinaldonetof merged 2 commits into
developfrom
fix.update-profile-shows-the-name
Jun 19, 2023
Merged

regression: fix blank 'Name' field in Profile View when modifying other fields#5101
reinaldonetof merged 2 commits into
developfrom
fix.update-profile-shows-the-name

Conversation

@reinaldonetof

@reinaldonetof reinaldonetof commented Jun 6, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

This pull request addresses an issue where modifying any field other than the 'Name' field in the Profile View resulted in the 'Name' field becoming blank. The fix ensures that the 'Name' field retains its value when making changes to other profile fields.

Regression from #4513

Issue(s)

How to test or reproduce

  • Change the field “Username”, "Email" or "New Password"
  • Click on Save

Screenshots

Before

Screen.Recording.2023-06-06.at.20.32.26.mov

After

Screen.Recording.2023-06-06.at.20.33.17.mov

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

TC-717

@reinaldonetof reinaldonetof self-assigned this Jun 6, 2023
@dnlsilva

dnlsilva commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

Does the fix remove the name?
That's what the after and before shows me.

It was working before, wasn't it?

@reinaldonetof

Copy link
Copy Markdown
Contributor Author

Does the fix remove the name? That's what the after and before shows me.

It was working before, wasn't it?

The screenshots were swapped. Now they are in correct order

@dnlsilva dnlsilva changed the title fix: blank 'Name' field in Profile View when modifying other fields regression: fix blank 'Name' field in Profile View when modifying other fields Jun 13, 2023
@reinaldonetof
reinaldonetof merged commit 557b464 into develop Jun 19, 2023
@reinaldonetof
reinaldonetof deleted the fix.update-profile-shows-the-name branch June 19, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants