Regression: Fix styles on FormTextInput - #4625
Merged
Merged
Conversation
diegolmello
requested changes
Oct 21, 2022
diegolmello
left a comment
diegolmello
left a comment
Member
There was a problem hiding this comment.
It's 39 height when it should be 48 as on Figma
diegolmello
approved these changes
Nov 4, 2022
diegolmello
pushed a commit
that referenced
this pull request
Dec 2, 2022
* Regression: Fix styles on FormTextInput * minor tweak padding icons * added 48 height
diegolmello
pushed a commit
that referenced
this pull request
Dec 2, 2022
* Regression: Fix styles on FormTextInput * minor tweak padding icons * added 48 height
navislavo
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* Regression: Fix styles on FormTextInput * minor tweak padding icons * added 48 height
navislavo
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* Regression: Fix styles on FormTextInput * minor tweak padding icons * added 48 height
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue(s)
we introduced a bug when typing a
gin this PR #4503How to test or reproduce
Screenshots
Before
After
Types of changes
Checklist
Further comments
Jira: NATIVE-90