Skip to content

[FIX] Team creation not adding members - #4588

Merged
dnlsilva merged 2 commits into
developfrom
fix/create-teams-with-members
Oct 18, 2022
Merged

[FIX] Team creation not adding members#4588
dnlsilva merged 2 commits into
developfrom
fix/create-teams-with-members

Conversation

@LucianoPierdona

@LucianoPierdona LucianoPierdona commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Update request of teams.create to use field members instead of users.

Issue(s)

How to test or reproduce

immediate test plan

  • Create a team with members
  • Make sure the members were added

others

  • Create a team without members

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@CLAassistant

CLAassistant commented Sep 30, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@dnlsilva dnlsilva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version was this change added to? Server version.
If for example it's a new version, you have to add a tag verifying which version it was in, because people use the updated app on old servers.

@dnlsilva
dnlsilva merged commit 6dd9578 into develop Oct 18, 2022
@dnlsilva
dnlsilva deleted the fix/create-teams-with-members branch October 18, 2022 11:39
diegolmello pushed a commit that referenced this pull request Dec 2, 2022
Co-authored-by: Gleidson Daniel Silva <gleidson10daniel@hotmail.com>
diegolmello pushed a commit that referenced this pull request Dec 2, 2022
Co-authored-by: Gleidson Daniel Silva <gleidson10daniel@hotmail.com>
navislavo pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Co-authored-by: Gleidson Daniel Silva <gleidson10daniel@hotmail.com>
navislavo pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Co-authored-by: Gleidson Daniel Silva <gleidson10daniel@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants