Skip to content

[FIX] Decrease space between sections on Lists View #4543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 5 commits into from
Sep 23, 2022
Merged

[FIX] Decrease space between sections on Lists View #4543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b045f31
[FIX] Decrease space between sections on Content Container Style Flat…
reinaldonetof Sep 19, 2022
bc92094
minor tweak in newmessageview, roommembersview, statusview
reinaldonetof Sep 19, 2022
b87a057
increase space from 8 to 16
reinaldonetof Sep 23, 2022
6971ec4
Make some changes
diegolmello Sep 23, 2022
f33a049
Update tests
diegolmello Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions __tests__/containers/List/__snapshots__/List.stories.storyshot
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion app/containers/List/ListContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import scrollPersistTaps from '../../lib/methods/helpers/scrollPersistTaps';

const styles = StyleSheet.create({
container: {
paddingVertical: 8
paddingVertical: 16
}
});

Expand Down
2 changes: 1 addition & 1 deletion app/containers/List/ListInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import I18n from '../../i18n';

const styles = StyleSheet.create({
container: {
paddingVertical: 4,
paddingTop: 8,
paddingHorizontal: PADDING_HORIZONTAL
},
text: {
Expand Down
2 changes: 1 addition & 1 deletion app/containers/List/ListSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Header } from '.';

const styles = StyleSheet.create({
container: {
marginBottom: 8
marginBottom: 16
}
});

Expand Down
2 changes: 1 addition & 1 deletion app/containers/List/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ import { StyleSheet } from 'react-native';

export const styles = StyleSheet.create({
contentContainerStyleFlatList: {
paddingVertical: 32
paddingVertical: 16
}
});
5 changes: 2 additions & 3 deletions app/views/CreateChannelView/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const styles = StyleSheet.create({
marginTop: 16
},
containerStyle: {
marginBottom: 28
marginBottom: 16
},
list: {
width: '100%'
Expand All @@ -53,8 +53,7 @@ const styles = StyleSheet.create({
paddingHorizontal: 16
},
buttonCreate: {
marginHorizontal: 16,
marginTop: 24
margin: 16
}
});

Expand Down
1 change: 1 addition & 0 deletions app/views/NotificationPreferencesView/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ const NotificationPreferencesView = (): React.ReactElement => {
testID='notification-preference-view-alert'
onChangeValue={saveNotificationSettings}
/>
<List.Separator />
<RenderListPicker
preference='audioNotificationValue'
room={room}
Expand Down
2 changes: 1 addition & 1 deletion app/views/RoomMembersView/components/ActionsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export default function ActionsSection({ rid, t, joined }: IActionsSection): Rea
};

return (
<View style={{ paddingTop: canAddUser || canInviteUser ? 16 : 0, paddingBottom: canAddUser || canInviteUser ? 8 : 0 }}>
<View style={{ paddingTop: canAddUser || canInviteUser ? 16 : 0, paddingBottom: canAddUser || canInviteUser ? 16 : 0 }}>
{['c', 'p'].includes(t) && canAddUser ? (
<>
<List.Separator />
Expand Down
4 changes: 2 additions & 2 deletions app/views/StatusView/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ const STATUS: IStatus[] = [

const styles = StyleSheet.create({
inputContainer: {
marginTop: 32,
marginBottom: 32
marginTop: 16,
marginBottom: 16
},
inputLeft: {
position: 'absolute',
Expand Down