Skip to content

Regression: Push notifications not working after update to Android 12 #4532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 3 commits into from
Sep 22, 2022
Merged

Regression: Push notifications not working after update to Android 12 #4532

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71cbea1
Remove unnecessary method from custom push notification
diegolmello Sep 15, 2022
653068d
Use immutable
diegolmello Sep 15, 2022
9031f40
Maybe
diegolmello Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions android/app/src/play/java/chat/rocket/reactnative/CustomPushNotification.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package chat.rocket.reactnative;

import static com.wix.reactnativenotifications.Defs.NOTIFICATION_RECEIVED_EVENT_NAME;

import android.app.Notification;
import android.app.NotificationChannel;
import android.app.NotificationManager;
Expand Down Expand Up @@ -35,8 +37,6 @@
import java.util.Map;
import java.util.concurrent.ExecutionException;

import static com.wix.reactnativenotifications.Defs.NOTIFICATION_RECEIVED_EVENT_NAME;

public class CustomPushNotification extends PushNotification {
public static ReactApplicationContext reactApplicationContext;
final NotificationManager notificationManager;
Expand Down Expand Up @@ -322,7 +322,12 @@ private void notificationReply(Notification.Builder notification, int notificati
replyIntent.setAction(KEY_REPLY);
replyIntent.putExtra("pushNotification", bundle);

PendingIntent replyPendingIntent = PendingIntent.getBroadcast(mContext, notificationId, replyIntent, PendingIntent.FLAG_UPDATE_CURRENT);
PendingIntent replyPendingIntent;
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
replyPendingIntent = PendingIntent.getBroadcast(mContext, notificationId, replyIntent, PendingIntent.FLAG_UPDATE_CURRENT | PendingIntent.FLAG_MUTABLE);
} else {
replyPendingIntent = PendingIntent.getBroadcast(mContext, notificationId, replyIntent, PendingIntent.FLAG_UPDATE_CURRENT);
}

RemoteInput remoteInput = new RemoteInput.Builder(KEY_REPLY)
.setLabel(label)
Expand All @@ -343,7 +348,7 @@ private void notificationDismiss(Notification.Builder notification, int notifica
Intent intent = new Intent(mContext, DismissNotification.class);
intent.putExtra(NOTIFICATION_ID, notificationId);

PendingIntent dismissPendingIntent = PendingIntent.getBroadcast(mContext, notificationId, intent, 0);
PendingIntent dismissPendingIntent = PendingIntent.getBroadcast(mContext, notificationId, intent, PendingIntent.FLAG_ONE_SHOT | PendingIntent.FLAG_IMMUTABLE);

notification.setDeleteIntent(dismissPendingIntent);
}
Expand Down