Skip to content

Conversation

@reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Sep 14, 2022

Proposed changes

Improve the search by the user at MessageBox to keep the same behavior as a web application, also fix the spotlight and add a param for rid when exists

Issue(s)

Closes #3681
Closes #4011

How to test or reproduce

Screenshots

First interaction with @


Screen Shot 2022-09-14 at 13 35 37

Screen.Recording.2022-09-14.at.13.36.39.mov

Interaction with @a


Screen Shot 2022-09-14 at 13 37 34

Screen.Recording.2022-09-14.at.13.37.05.mov

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: TC-37

@ankar84
Copy link
Contributor

ankar84 commented Sep 28, 2022

Wait a lot that PR is merged

@diegolmello
Copy link
Member

@ankar84 we're releasing 4.31.0. We want to land this fix on 4.32.0

@reinaldonetof reinaldonetof merged commit 57620ff into develop Oct 31, 2022
@reinaldonetof reinaldonetof deleted the fix.spotlight-orders branch October 31, 2022 16:43
diegolmello pushed a commit that referenced this pull request Dec 2, 2022
* [IMPROVE] Spotlight users order

* minor tweak query

* minor tweak removing query and using regex

* minor tweak

* minor tweak, make ts happy

* fix the ts

* fix lint and type TSearch
diegolmello pushed a commit that referenced this pull request Dec 2, 2022
* [IMPROVE] Spotlight users order

* minor tweak query

* minor tweak removing query and using regex

* minor tweak

* minor tweak, make ts happy

* fix the ts

* fix lint and type TSearch
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* [IMPROVE] Spotlight users order

* minor tweak query

* minor tweak removing query and using regex

* minor tweak

* minor tweak, make ts happy

* fix the ts

* fix lint and type TSearch
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* [IMPROVE] Spotlight users order

* minor tweak query

* minor tweak removing query and using regex

* minor tweak

* minor tweak, make ts happy

* fix the ts

* fix lint and type TSearch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logic of mention suggestions differs of Web version

5 participants