Skip to content

[FIX] Decrease space between sections on List - #4520

Merged
reinaldonetof merged 6 commits into
developfrom
fix.decrease-space-room-info
Sep 19, 2022
Merged

[FIX] Decrease space between sections on List#4520
reinaldonetof merged 6 commits into
developfrom
fix.decrease-space-room-info

Conversation

@reinaldonetof

Copy link
Copy Markdown
Contributor

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Before

a b c d
Screen Shot 2022-09-12 at 14 56 38 Screen Shot 2022-09-12 at 14 57 29 Screen Shot 2022-09-12 at 14 57 56 Screen Shot 2022-09-12 at 14 58 19

After

a b c d
Screen Shot 2022-09-12 at 15 01 18 Screen Shot 2022-09-12 at 15 00 55 Screen Shot 2022-09-12 at 15 00 26 Screen Shot 2022-09-12 at 14 59 56

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few more changes for header/info components. I hope you don't mind :)
Here are some before/after and the screenshots of unchanged stuff.

Can you re-review?

Screen Shot 2022-09-19 at 14 27 13
Screen Shot 2022-09-19 at 14 26 51
Screen Shot 2022-09-19 at 14 26 38
Screen Shot 2022-09-19 at 14 26 18
Screen Shot 2022-09-19 at 14 25 42

@reinaldonetof
reinaldonetof merged commit 05c1798 into develop Sep 19, 2022
@reinaldonetof
reinaldonetof deleted the fix.decrease-space-room-info branch September 19, 2022 18:14
diegolmello added a commit that referenced this pull request Sep 28, 2022
* [FIX] Decrease space between sections on List

* minor tweak listcontainer

* update test

* Small fixes for header/info

* Update tests

Co-authored-by: Diego Mello <diegolmello@gmail.com>
navislavo pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* [FIX] Decrease space between sections on List

* minor tweak listcontainer

* update test

* Small fixes for header/info

* Update tests

Co-authored-by: Diego Mello <diegolmello@gmail.com>
navislavo pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* [FIX] Decrease space between sections on List

* minor tweak listcontainer

* update test

* Small fixes for header/info

* Update tests

Co-authored-by: Diego Mello <diegolmello@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants