Skip to content

Chore: Hooks app/views/DefaultBrowserView - #4424

Merged
reinaldonetof merged 8 commits into
developfrom
chore.hooks-defaultbrowserview
Aug 19, 2022
Merged

Chore: Hooks app/views/DefaultBrowserView#4424
reinaldonetof merged 8 commits into
developfrom
chore.hooks-defaultbrowserview

Conversation

@reinaldonetof

@reinaldonetof reinaldonetof commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Migrate DefaultBrowserView to hooks

Issue(s)

How to test or reproduce

  • After logged
  • Join a room, click on any link and see how the web page is opened
  • Then, go to Settings and click on Default browser
  • Change to another type of browser, back to that room in step 2 and open again the link

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Aug 9, 2022
diegolmello
diegolmello previously requested changes Aug 10, 2022
View reviewed changes
Comment thread app/views/DefaultBrowserView.tsx Outdated
Comment thread app/views/DefaultBrowserView.tsx
dnlsilva
dnlsilva suggested changes Aug 12, 2022
View reviewed changes
Comment thread app/views/DefaultBrowserView/index.tsx Outdated
Comment thread app/views/DefaultBrowserView/Item.tsx Outdated
Comment thread app/views/DefaultBrowserView/index.tsx
dnlsilva
dnlsilva suggested changes Aug 18, 2022
View reviewed changes
Comment thread app/views/DefaultBrowserView/Item.tsx Outdated
Comment thread app/views/DefaultBrowserView/index.tsx Outdated
@reinaldonetof
reinaldonetof merged commit ded2f37 into develop Aug 19, 2022
@reinaldonetof
reinaldonetof deleted the chore.hooks-defaultbrowserview branch August 19, 2022 13:46
diegolmello pushed a commit that referenced this pull request Sep 12, 2022
@reinaldonetof @diegolmello
Chore: Hooks app/views/DefaultBrowserView (#4424)
7da5801 
* Chore: Hooks app/views/DefaultBrowserView

* fix type

* minor tweak

* item on new file

* minor tweaks

* minor tweak
@reinaldonetof reinaldonetof mentioned this pull request Sep 23, 2022
Merged
10 tasks
navislavo pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@reinaldonetof
Chore: Hooks app/views/DefaultBrowserView (RocketChat#4424)
b9e12bc 
* Chore: Hooks app/views/DefaultBrowserView

* fix type

* minor tweak

* item on new file

* minor tweaks

* minor tweak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegolmello diegolmello diegolmello left review comments
+1 more reviewer
@dnlsilva dnlsilva dnlsilva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@reinaldonetof reinaldonetof

Labels

🚚 chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reinaldonetof @diegolmello @dnlsilva