Skip to content

Chore: Migrate E2EHowItWorksView to hooks - #4416

Merged
dnlsilva merged 6 commits into
developfrom
how-it-works-view-hooks
Aug 11, 2022
Merged

Chore: Migrate E2EHowItWorksView to hooks#4416
dnlsilva merged 6 commits into
developfrom
how-it-works-view-hooks

Conversation

@dnlsilva

@dnlsilva dnlsilva commented Aug 8, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Migrate E2EHowItWorksView to hooks

Issue(s)

How to test or reproduce

Test E2EHowItWorksView screen

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello
diegolmello force-pushed the how-it-works-view-hooks branch from 6a8def2 to fad548d Compare August 9, 2022 21:26
interface IMarkdownProps {
msg?: string | null;
theme: TSupportedThemes;
theme?: TSupportedThemes;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad, but I get it 😭

@dnlsilva
dnlsilva merged commit 92111af into develop Aug 11, 2022
@dnlsilva
dnlsilva deleted the how-it-works-view-hooks branch August 11, 2022 14:50
diegolmello pushed a commit that referenced this pull request Sep 12, 2022
* remove navigation obligatory

* remove the obliglatory to use theme with the withTheme HOC

* migrate E2EHowItWorksView to hooks

* remove navigate options

* adds non-null assertion because theme is injected
navislavo pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* remove navigation obligatory

* remove the obliglatory to use theme with the withTheme HOC

* migrate E2EHowItWorksView to hooks

* remove navigate options

* adds non-null assertion because theme is injected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants