Skip to content

Chore: Improve code and migrate some props to hooks on ThemeView - #4414

Merged
diegolmello merged 8 commits into
developfrom
theme-view-hooks
Sep 12, 2022
Merged

Chore: Improve code and migrate some props to hooks on ThemeView#4414
diegolmello merged 8 commits into
developfrom
theme-view-hooks

Conversation

@dnlsilva

@dnlsilva dnlsilva commented Aug 8, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Improve code and migrate some props to hooks on ThemeView

Issue(s)

How to test or reproduce

Test the screen ThemeView

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Comment thread app/views/ThemeView.tsx Outdated
Comment thread app/views/ThemeView.tsx Outdated
Comment thread app/views/ThemeView.tsx Outdated
Comment thread app/views/ThemeView.tsx
@diegolmello
diegolmello merged commit 989ced8 into develop Sep 12, 2022
@diegolmello
diegolmello deleted the theme-view-hooks branch September 12, 2022 13:16
diegolmello pushed a commit that referenced this pull request Sep 28, 2022
Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>
navislavo pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
…ketChat#4414)

Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>
navislavo pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
…ketChat#4414)

Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants