Repository navigation
[IMPROVE] Add All tab in Reactions List
#4409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
e2553d4
Add 'All' tab in Reactions List
try-catch-stack 6ae31b1
Add names to message reactions
try-catch-stack 3797933
useRealName settings
try-catch-stack 1debafa
Move ReactionsList components to separate files
try-catch-stack 78f17c6
Add unit tests and storybook stories
try-catch-stack d5bfbc2
Add detox test
try-catch-stack 2adbfcb
Fix UsersList styles
diegolmello 501bfca
Move useSelector to top
diegolmello 8a891a4
ListHeaderComponent can be a React component instead of a function
diegolmello ff4e50b
Fixing more styles
diegolmello cde3ec7
All tab emojis
diegolmello fc8e85b
Fix tab styles
diegolmello 40e3346
Fix flatlist notch
diegolmello 3e2a0e8
Fixing tab styles
diegolmello 75afd5d
Update snapshots
diegolmello fbd5cf4
Fix tabWidth issue on landscape and useRealName on all tab
try-catch-stack 51602c6
Merge branch 'develop' into improve.reactions-list
diegolmello ea30a99
Fix storybook not displaying the component
diegolmello 2f2e955
Stop baseUrl prop drill
diegolmello c06e66b
Stop width prop drill
diegolmello 746d8a5
baseUrl and width on RoomView
diegolmello fba798f
Add 80% snap
diegolmello 21bf216
Update tests
diegolmello a9f8797
Remove username prop drill and fix some tests
diegolmello efc03af
Minor style change on header
diegolmello dc599c5
Update detox tests
diegolmello File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After I react, it doesn't apply use real name anymore
Simulator.Screen.Recording.-.iPhone.11.Pro.-.2022-09-01.at.12.54.43.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could reproduce this on web app as well so probably an issue with the API.