Skip to content

[FIX] Text composer is pushing modals outside the screen on Android's tablet - #4393

Merged
reinaldonetof merged 7 commits into
developfrom
fix.modal-tablet
Aug 11, 2022
Merged

[FIX] Text composer is pushing modals outside the screen on Android's tablet#4393
reinaldonetof merged 7 commits into
developfrom
fix.modal-tablet

Conversation

@reinaldonetof

@reinaldonetof reinaldonetof commented Jul 27, 2022 •
edited by diegolmello
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

On Android tablets, text composer is pushing modals outside the screen

Issue(s)

How to test or reproduce

  • Open "settings"
  • Tap on the user's "status"
  • Tap on the text field
  • Try it both on Android and iPad

Screenshots

Before

image

After

Screen Shot 2022-07-26 at 22 19 02

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Jul 27, 2022
diegolmello
diegolmello requested changes Jul 28, 2022
View reviewed changes
Comment thread app/lib/hooks/useKeyboardHeight.ts Outdated
Comment thread app/stacks/MasterDetailStack/ModalContainer.tsx Outdated
Comment thread app/stacks/MasterDetailStack/ModalContainer.tsx Outdated
@reinaldonetof
reinaldonetof merged commit 0c8177e into develop Aug 11, 2022
@reinaldonetof
reinaldonetof deleted the fix.modal-tablet branch August 11, 2022 18:50
diegolmello pushed a commit that referenced this pull request Sep 12, 2022
@reinaldonetof @diegolmello
[FIX] Text composer is pushing modals outside the screen on Android's…
049d24d 
… tablet (#4393)

* [FIX] Text composer is pushing modals outside the screen

* added isLandscape

* refactor useKeyboard

* refactor landscape
navislavo pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@reinaldonetof
[FIX] Text composer is pushing modals outside the screen on Android's…
4223a2e 
… tablet (RocketChat#4393)

* [FIX] Text composer is pushing modals outside the screen

* added isLandscape

* refactor useKeyboard

* refactor landscape
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegolmello diegolmello diegolmello approved these changes
+1 more reviewer
@dnlsilva dnlsilva dnlsilva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@reinaldonetof reinaldonetof

Labels

🛠 fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reinaldonetof @diegolmello @dnlsilva