Skip to content

[FIX] iFrame login takes user to blank screen - #4389

Merged
reinaldonetof merged 2 commits into
developfrom
fix.iframe-blank-screen
Jul 29, 2022
Merged

[FIX] iFrame login takes user to blank screen#4389
reinaldonetof merged 2 commits into
developfrom
fix.iframe-blank-screen

Conversation

@reinaldonetof

Copy link
Copy Markdown
Contributor

Proposed changes

The user should be redirected to a screen that allows them to continue the login process.

Issue(s)

How to test or reproduce

Given there has already been an iframe login made

  • Go to the app's first screen and tap on the "workspace URL" field
  • choose the "iframe" server from the dropdown

Screenshots

Before

Screen.Recording.2022-07-25.at.15.53.07.mov

After

Screen.Recording.2022-07-25.at.15.51.28.mov

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof
reinaldonetof merged commit d7f7b1d into develop Jul 29, 2022
@reinaldonetof
reinaldonetof deleted the fix.iframe-blank-screen branch July 29, 2022 04:18
navislavo pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants