[IMPROVE] Add support to Linebreak and Katex on markdown - #4361
Merged
Conversation
dnlsilva
changed the title
diegolmello
force-pushed
the
fix-new-markdown
branch
from
July 14, 2022 13:47
883d17b to
f6f813f
Compare
diegolmello
requested changes
Jul 14, 2022
diegolmello
approved these changes
Jul 18, 2022
diegolmello
changed the title
diegolmello
pushed a commit
that referenced
this pull request
Sep 12, 2022
* fix enableMessageParser logic * create LineBreak component * fix code style * add KaTeX support * add Katex and Inline Katex stories * update snapshots * add color prop * update snapshot * update snapshot
navislavo
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
…4361) * fix enableMessageParser logic * create LineBreak component * fix code style * add KaTeX support * add Katex and Inline Katex stories * update snapshots * add color prop * update snapshot * update snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes the issue of texts in markdown not skipping lines when the component is Code, and the spacing when having a line break.
Add KaTeX support.
Issue(s)
Closes #1973
How to test or reproduce
Send this message to other user:
Screenshots
Before:
After:
Types of changes
Checklist
Further comments
Inline KaTeX is currently not supported due to parse issues, however there is an open issue:
RocketChat/fuselage#775