[IMPROVE] Redesign emoji picker - #4328
Merged
Merged
Conversation
dnlsilva
reviewed
Jun 29, 2022
try-catch-stack
force-pushed
the
new.emoji-picker
branch
3 times, most recently
from
June 30, 2022 21:32
94d9cfb to
0f055d0
Compare
diegolmello
requested changes
Jul 13, 2022
try-catch-stack
force-pushed
the
new.emoji-picker
branch
from
July 14, 2022 13:57
6131ded to
96d1e84
Compare
diegolmello
requested changes
Jul 19, 2022
diegolmello
reviewed
Jul 19, 2022
dnlsilva
suggested changes
Jul 27, 2022
dnlsilva
left a comment
Contributor
There was a problem hiding this comment.
errors:
When you send an emoji the keyboard does not close automatically.
When clicking directly on the emoji without clicking on the keyboard, when I switch to keyboard it doesn't work, the keyboard is black.
Contributor
Author
I believe, this issue should now be fixed. |
try-catch-stack
force-pushed
the
new.emoji-picker
branch
2 times, most recently
from
August 10, 2022 20:09
850d058 to
5d79415
Compare
10 tasks
diegolmello
requested changes
Aug 19, 2022
try-catch-stack
force-pushed
the
new.emoji-picker
branch
3 times, most recently
from
August 21, 2022 12:20
049a272 to
16a7dcd
Compare
diegolmello
force-pushed
the
new.emoji-picker
branch
from
October 20, 2022 17:22
bb50af1 to
532fb3c
Compare
diegolmello
approved these changes
Oct 20, 2022
dnlsilva
suggested changes
Oct 21, 2022
Contributor
dnlsilva
approved these changes
Oct 21, 2022
diegolmello
added a commit
that referenced
this pull request
Dec 2, 2022
Co-authored-by: Diego Mello <diegolmello@gmail.com>
diegolmello
added a commit
that referenced
this pull request
Dec 2, 2022
Co-authored-by: Diego Mello <diegolmello@gmail.com>
navislavo
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
Co-authored-by: Diego Mello <diegolmello@gmail.com>
navislavo
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
Co-authored-by: Diego Mello <diegolmello@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed changes
EmojiPickerto hooks.EmojiPickercomponent. Added functionality tosearchanddeleteemojis.Issue(s)
How to test or reproduce
Note: We have a default emojis list on some places and they are composed of

['clap', 'thumbsup', 'heart_eyes', 'grinning', 'thinking', 'smiley']Once the user starts selecting emojis, the app starts to replace this default list with this
frequently usedemojis.Add emoji to message composer from emoji keyboard
Add emoji to message composer from emoji keyboard's search (clear cache before running this test)
Add emoji to message composer from autocomplete
:to open emoji autocompleteReact a message from message actions (clear cache before this one)
React a message from reaction picker
"smile emoji +"on the top right of the bottom sheet. It should open the reaction picker. Then select an emoji to react.Remove reaction
Others
Screenshots
Searching emojis:
new.emoji-picker.mp4
Types of changes
Checklist
Further comments
NATIVE-109