Chore: Migrate NotificationPreferencesView to hooks - #4327
Merged
Conversation
dnlsilva
force-pushed
the
notification-preferences-view
branch
from
June 28, 2022 19:46
db6670c to
e8ae963
Compare
|
This pull request fixes 1 alert when merging e8ae963 into e48527b - view on LGTM.com fixed alerts:
|
diegolmello
previously requested changes
Jul 18, 2022
|
This pull request fixes 1 alert when merging 4ff9384 into 60f781d - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 3e9d1ee into 376c8e8 - view on LGTM.com fixed alerts:
|
reinaldonetof
suggested changes
Jul 22, 2022
| testID={preference as string} | ||
| trackColor={SWITCH_TRACK_COLOR} | ||
| onValueChange={value => { | ||
| onChangeValue(preference, { [preference]: switchValue ? '1' : '0' }, () => setSwitchValue(switchValue)); |
Contributor
There was a problem hiding this comment.
WDYT to use named params?
|
This pull request fixes 1 alert when merging bcf0480 into 376c8e8 - view on LGTM.com fixed alerts:
|
reinaldonetof
approved these changes
Jul 25, 2022
|
This pull request fixes 1 alert when merging 92e8f5c into 376c8e8 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging d606718 into 376c8e8 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging e56c14e into 5875454 - view on LGTM.com fixed alerts:
|
diegolmello
pushed a commit
that referenced
this pull request
Sep 12, 2022
* add none option * create showErrorAlertWithEMessage function * migrate NotificationPreferencesView to hooks and improves overall * change icon to right * fix navigation options * remove none * fix types * remove memo * cleaning * switching to destructuring * add observe for hideUnreadStatus * fix desktop options * remove unused options Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>
navislavo
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* add none option * create showErrorAlertWithEMessage function * migrate NotificationPreferencesView to hooks and improves overall * change icon to right * fix navigation options * remove none * fix types * remove memo * cleaning * switching to destructuring * add observe for hideUnreadStatus * fix desktop options * remove unused options Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Migrate NotificationPreferencesView to hooks and improves layout and user feedback
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments