Skip to content

[FIX] Comment out abort requests logic - #4311

Closed
diegolmello wants to merge 1 commit into
developfrom
fix.comment-abort
Closed

[FIX] Comment out abort requests logic#4311
diegolmello wants to merge 1 commit into
developfrom
fix.comment-abort

Conversation

@diegolmello

Copy link
Copy Markdown
Member

Proposed changes

We still have some AbortController logics to abort some requests when the server is changed, but they're not working for some time now.
As we'll have to think on a better solution for hooks, like react-query, it's a good moment to comment out the current logics and assess the impact.
It's going to fix some known issues, like totp not working properly after some time.

Issue(s)

https://app.clickup.com/t/225v2r1

How to test or reproduce

2FA modal not showing up

  • I used our "google OAuth", configured on our open servers, to reproduce it.
  • Tap "join our open workspace"
  • tap "login"
  • Use Google OAuth but choose to cancel the process once the 2FA modal appears.
  • Go back to the first screen (workspaces)
  • Repeat steps from 1

Switch servers

  • Switch servers back and forth and everything should keep working

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello

Copy link
Copy Markdown
Member Author

Closing in favor of #4429

@diegolmello
diegolmello deleted the fix.comment-abort branch August 11, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants