[FIX] Comment out abort requests logic - #4311
Closed
diegolmello wants to merge 1 commit into
Closed
Conversation
dnlsilva
approved these changes
Jun 21, 2022
diegolmello
force-pushed
the
fix.comment-abort
branch
from
June 22, 2022 20:02
cd606c0 to
05cbb55
Compare
Member
Author
|
Closing in favor of #4429 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
We still have some AbortController logics to abort some requests when the server is changed, but they're not working for some time now.
As we'll have to think on a better solution for hooks, like react-query, it's a good moment to comment out the current logics and assess the impact.
It's going to fix some known issues, like totp not working properly after some time.
Issue(s)
https://app.clickup.com/t/225v2r1
How to test or reproduce
2FA modal not showing up
Switch servers
Screenshots
Types of changes
Checklist
Further comments