Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix develop build for iOS devices #4208

Merged
merged 1 commit into from
May 23, 2022
Merged

Conversation

dnlsilva
Copy link
Contributor

@dnlsilva dnlsilva commented May 18, 2022

Proposed changes

Fix develop build for real devices

Honestly I don't think it's necessary to merge this, probably with the update of react native this issue will be resolved.

Related to: facebook/react-native#32453

Issue(s)

Closes #3371

How to test or reproduce

Run on a real device using Xcode

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello changed the title Chore: Fix develop build for real devices Chore: Fix develop build for iOS devices May 20, 2022
@dnlsilva dnlsilva force-pushed the fix/fix-real-device-build branch from 24f8481 to 01b8cd2 Compare May 23, 2022 17:17
@dnlsilva dnlsilva merged commit 5f621cb into develop May 23, 2022
@dnlsilva dnlsilva deleted the fix/fix-real-device-build branch May 23, 2022 17:24
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid regular expression: Quantifier has nothing to repeat Error on Xcode 12.5
2 participants