Skip to content

Chore: Migrate REST API - getThreadsList to Typescript #3895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexAlexandre merged 4 commits into from
Mar 17, 2022
Merged

Chore: Migrate REST API - getThreadsList to Typescript #3895

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03bbd82
chore: add rest api return
AlexAlexandre Mar 15, 2022
647b64b
Merge branch 'develop' into chore/getThreadsList
AlexAlexandre Mar 16, 2022
2a25bb5
chore: removing sort param
AlexAlexandre Mar 16, 2022
8b0d47d
Merge branch 'develop' into chore/getThreadsList
AlexAlexandre Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/definitions/rest/v1/chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export type ChatEndpoints = {
'chat.getThreadsList': {
GET: (params: {
rid: IServerRoom['_id'];
type: 'unread' | 'following' | 'all';
type?: 'unread' | 'following' | 'all';
text?: string;
offset: number;
count: number;
Expand Down
7 changes: 3 additions & 4 deletions app/lib/rocketchat/services/restApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,12 +654,11 @@ export const toggleFollowMessage = (mid: string, follow: boolean) => {
};

export const getThreadsList = ({ rid, count, offset, text }: { rid: string; count: number; offset: number; text?: string }) => {
const params: any = {
const params = {
rid,
count,
offset,
sort: { ts: -1 }
};
offset
} as { rid: string; count: number; offset: number; text?: string };
if (text) {
params.text = text;
}
Expand Down
2 changes: 1 addition & 1 deletion app/views/ThreadMessagesView/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ class ThreadMessagesView extends React.Component<IThreadMessagesViewProps, IThre
this.setState({ loading: true });

try {
const result: any = await RocketChat.getThreadsList({
const result = await RocketChat.getThreadsList({
rid: this.rid,
count: API_FETCH_COUNT,
offset: messages.length,
Expand Down