Skip to content

Chore: Migrate REST API - saveAutoTranslate to Typescript #3892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexAlexandre merged 2 commits into from
Mar 16, 2022
Merged

Chore: Migrate REST API - saveAutoTranslate to Typescript #3892

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d531648
chore: add rest api return
AlexAlexandre Mar 15, 2022
aa9823c
Merge branch 'develop' into chore/saveAutoTranslate
AlexAlexandre Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions app/lib/rocketchat/services/restApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,8 +726,17 @@ export const getDirectory = ({ query, count, offset, sort }: { query: any; count
sort
});

export const saveAutoTranslate = ({ rid, field, value, options }: { rid: string; field: string; value: any; options: any }) =>
sdk.methodCallWrapper('autoTranslate.saveSettings', rid, field, value, options);
export const saveAutoTranslate = ({
rid,
field,
value,
options
}: {
rid: string;
field: string;
value: string;
options?: { defaultLanguage: string };
}) => sdk.methodCallWrapper('autoTranslate.saveSettings', rid, field, value, options ?? null);

export const getSupportedLanguagesAutoTranslate = () => sdk.methodCallWrapper('autoTranslate.getSupportedLanguages', 'en');

Expand Down
4 changes: 1 addition & 3 deletions app/views/AutoTranslateView/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,10 @@ class AutoTranslateView extends React.Component<IAutoTranslateViewProps, any> {
saveAutoTranslateLanguage = async (language: string) => {
logEvent(events.AT_SET_LANG);
try {
// TODO: remove the parameter options, after migrate the RocketChat
await RocketChat.saveAutoTranslate({
rid: this.rid,
field: 'autoTranslateLanguage',
value: language,
options: null
value: language
});
this.setState({ selectedLanguage: language });
} catch (error) {
Expand Down