Skip to content

Chore: Migrate REST API - getCustomFields to Typescript #3856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reinaldonetof merged 4 commits into from
Mar 8, 2022
Merged

Chore: Migrate REST API - getCustomFields to Typescript #3856

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5889801
Chore: Migrate REST API - getCustomFields to Typescript
reinaldonetof Mar 8, 2022
4c32750
minor tweak
reinaldonetof Mar 8, 2022
6f8acb0
Merge branch 'develop' into chore.ts-getcustomfields
reinaldonetof Mar 8, 2022
ccdfc74
Merge branch 'develop' into chore.ts-getcustomfields
reinaldonetof Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/definitions/rest/v1/omnichannel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ export type OmnichannelEndpoints = {
{
_id: string;
label: string;
visibility?: string;
scope?: string;
}
];
}>;
Expand Down
20 changes: 7 additions & 13 deletions app/views/LivechatEditView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,6 @@ interface ITitle {
theme: string;
}

interface IField {
_id: string;
visibility: string;
scope: string;
}

interface IInputs {
livechatData: {
[key: string]: any;
Expand Down Expand Up @@ -115,17 +109,17 @@ const LivechatEditView = ({
const visitor = route.params?.roomUser ?? {};

const getCustomFields = async () => {
const result: any = await RocketChat.getCustomFields();
const result = await RocketChat.getCustomFields();
if (result.success && result.customFields?.length) {
const visitorCustomFields = result.customFields
.filter((field: IField) => field.visibility !== 'hidden' && field.scope === 'visitor')
.map((field: IField) => ({ [field._id]: (visitor.livechatData && visitor.livechatData[field._id]) || '' }))
.reduce((ret: IField, field: IField) => ({ ...field, ...ret }));
.filter(field => field.visibility !== 'hidden' && field.scope === 'visitor')
.map(field => ({ [field._id]: (visitor.livechatData && visitor.livechatData[field._id]) || '' }))
.reduce((ret, field) => ({ ...field, ...ret }), {});

const livechatCustomFields = result.customFields
.filter((field: IField) => field.visibility !== 'hidden' && field.scope === 'room')
.map((field: IField) => ({ [field._id]: (livechat.livechatData && livechat.livechatData[field._id]) || '' }))
.reduce((ret: IField, field: IField) => ({ ...field, ...ret }));
.filter(field => field.visibility !== 'hidden' && field.scope === 'room')
.map(field => ({ [field._id]: (livechat.livechatData && livechat.livechatData[field._id]) || '' }))
.reduce((ret, field) => ({ ...field, ...ret }), {});

return setCustomFields({ visitor: visitorCustomFields, livechat: livechatCustomFields });
}
Expand Down