Skip to content

Chore: Migrate REST API - getTagsList to Typescript #3854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reinaldonetof merged 2 commits into from
Mar 8, 2022
Merged

Chore: Migrate REST API - getTagsList to Typescript #3854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d92c42
Chore: Migrate REST API - getTagsList to Typescript
reinaldonetof Mar 7, 2022
6237859
Merge branch 'develop' into chore.ts-gettagslist
reinaldonetof Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions app/definitions/ITagsOmnichannel.ts
View file
Open in desktop

This file was deleted.

8 changes: 7 additions & 1 deletion app/lib/rocketchat/services/restApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,13 @@ export const getRoutingConfig = (): Promise<{
// RC 2.0.0
sdk.methodCallWrapper('livechat:getRoutingConfig');

export const getTagsList = () =>
export const getTagsList = (): Promise<
{
_id: string;
name: string;
departments: string[];
}[]
> =>
// RC 2.0.0
sdk.methodCallWrapper('livechat:getTagsList');

Expand Down
3 changes: 1 addition & 2 deletions app/views/LivechatEditView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import Button from '../containers/Button';
import SafeAreaView from '../containers/SafeAreaView';
import { MultiSelect } from '../containers/UIKit/MultiSelect';
import { ILivechatVisitor } from '../definitions/ILivechatVisitor';
import { ITagsOmnichannel } from '../definitions/ITagsOmnichannel';
import { IApplicationState, ISubscription } from '../definitions';
import { ChatsStackParamList } from '../stacks/types';
import sharedStyles from './Styles';
Expand Down Expand Up @@ -142,7 +141,7 @@ const LivechatEditView = ({
}, [availableUserTags]);

const getTagsList = async (agentDepartments: string[]) => {
const tags: ITagsOmnichannel[] = await RocketChat.getTagsList();
const tags = await RocketChat.getTagsList();
const isAdmin = ['admin', 'livechat-manager'].find(role => user.roles.includes(role));
const availableTags = tags
.filter(({ departments }) => isAdmin || departments.length === 0 || departments.some(i => agentDepartments.indexOf(i) > -1))
Expand Down