Skip to content

Chore: Migrate REST API - getRoomCounters to Typescript #3842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reinaldonetof merged 6 commits into from
Mar 7, 2022
Merged

Chore: Migrate REST API - getRoomCounters to Typescript #3842

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7fdf52d
Chore: Migrate REST API - getRoomCounters to Typescript
reinaldonetof Mar 5, 2022
761b2d4
minor tweak
reinaldonetof Mar 5, 2022
2b79d4e
Merge branch 'develop' into chore.ts-getroomcounters
reinaldonetof Mar 7, 2022
1d6b0e6
Merge branch 'develop' into chore.ts-getroomcounters
reinaldonetof Mar 7, 2022
8b574ef
Merge branch 'develop' into chore.ts-getroomcounters
reinaldonetof Mar 7, 2022
5e2b25d
Merge branch 'develop' into chore.ts-getroomcounters
reinaldonetof Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app/definitions/rest/v1/channels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,15 @@ export type ChannelsEndpoints = {
'channels.convertToTeam': {
POST: (params: { channelId: string; channelName: string }) => { team: ITeam };
};
'channels.counters': {
GET: (params: { roomId: string }) => {
joined: boolean;
members: number;
unreads: number;
unreadsFrom: Date;
msgs: number;
latest: Date;
userMentions: number;
};
};
};
11 changes: 11 additions & 0 deletions app/definitions/rest/v1/groups.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,15 @@ export type GroupsEndpoints = {
'groups.convertToTeam': {
POST: (params: { roomId: string; roomName: string }) => { team: ITeam };
};
'groups.counters': {
GET: (params: { roomId: string }) => {
joined: boolean;
members: number;
unreads: number;
unreadsFrom: Date;
msgs: number;
latest: Date;
userMentions: number;
};
};
};
7 changes: 4 additions & 3 deletions app/lib/rocketchat/services/restApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,10 +300,11 @@ export const getUserRoles = () =>
// RC 0.27.0
sdk.methodCallWrapper('getUserRoles');

export const getRoomCounters = (roomId: string, t: RoomTypes): any =>
export const getRoomCounters = (
roomId: string,
t: SubscriptionType.CHANNEL | SubscriptionType.GROUP | SubscriptionType.OMNICHANNEL
) =>
// RC 0.65.0
// TODO: missing definitions from server
// @ts-ignore
sdk.get(`${roomTypeToApiType(t)}.counters`, { roomId });

export const getChannelInfo = (roomId: string): any =>
Expand Down