Skip to content

Chore: Migrate REST API - getChannelInfo to TS #3839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gerzonc merged 4 commits into from
Mar 8, 2022
Merged

Chore: Migrate REST API - getChannelInfo to TS #3839

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c58bab1
add: type for REST API `channels.info`
gerzonc Mar 4, 2022
488ef49
add: `ts-ignore` to `RoomActionsView`
gerzonc Mar 7, 2022
a3f4556
Merge branch 'develop' into chore.getchannelinfo-to-ts
gerzonc Mar 7, 2022
1147d81
Merge branch 'develop' into chore.getchannelinfo-to-ts
gerzonc Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/definitions/rest/v1/channels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,7 @@ export type ChannelsEndpoints = {
'channels.convertToTeam': {
POST: (params: { channelId: string; channelName: string }) => { team: ITeam };
};
'channels.info': {
GET: (params: { roomId: string }) => { channel: IServerRoomItem };
};
};
4 changes: 1 addition & 3 deletions app/lib/rocketchat/services/restApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,10 +306,8 @@ export const getRoomCounters = (roomId: string, t: RoomTypes): any =>
// @ts-ignore
sdk.get(`${roomTypeToApiType(t)}.counters`, { roomId });

export const getChannelInfo = (roomId: string): any =>
export const getChannelInfo = (roomId: string) =>
// RC 0.48.0
// TODO: missing definitions from server
// @ts-ignore
sdk.get('channels.info', { roomId });

export const getUserPreferences = (userId: string): any =>
Expand Down
2 changes: 1 addition & 1 deletion app/views/RoomActionsView/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ class RoomActionsView extends React.Component<IRoomActionsViewProps, IRoomAction
try {
const result = await RocketChat.getChannelInfo(room.rid);
if (result.success) {
this.setState({ room: { ...result.channel, rid: result.channel._id } });
this.setState({ room: { ...result.channel, rid: result.channel._id } as any });
Comment thread
gerzonc marked this conversation as resolved.
Outdated
}
} catch (e) {
log(e);
Expand Down